Add support for pause
#908
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@haircommander @rphillips do you think this would work? The main idea is that conmonrs calls it self via |
saschagrunert
force-pushed
the
pause
branch
14 times, most recently
from
c8536b3
to
473c678
Compare
saschagrunert
force-pushed
the
pause
branch
5 times, most recently
from
b7ef385
to
4ac924b
Compare
saschagrunert
force-pushed
the
pause
branch
3 times, most recently
from
cdb151f
to
f0b26e5
Compare
saschagrunert
force-pushed
the
pause
branch
4 times, most recently
from
486cc3d
to
49365e9
Compare
|
Ready for review. PTAL @rphillips @haircommander |
|
if conmon-rs exits, are we making sure the pause processes are stopped? I think otherwise they'd leak |
|
This experiment adds support for running a global shared pause instance side by side to `conmonrs`. The idea is that this instance keeps the required namespaces open and provides them as part of the container creation response to the consumers. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
Gave it a rebase. |
|
This looks ready to me. Nice job... @haircommander ? |
|
/lgtm |
|
well done here! |
| const PAUSE_PATH: &str = "/var/run/conmonrs"; | ||
|
|
||
| /// The file path for storing the pause PID. | ||
| const PAUSE_PID_FILE: &str = ".pause_pid"; |
There was a problem hiding this comment.
Would it make sense to run this as a systemd unit instead?
There was a problem hiding this comment.
Hm, I'm not sure about the resource overhead we add when using systemd here. We can definitely give it a try and see how it behaves. Opened #1041 for tracking.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This experiment adds support for running a global shared pause instance side by side to
conmonrs. The idea is that this instance keeps the required namespaces open and provides them as part of the container creation response to the consumers.Which issue(s) this PR fixes:
Refers to #871
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?