Make 'docs' target not depend on 'install.tools' if GOMD2MAN is set #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the GOMD2MAN (environment) variable is set, then we do not need the 'docs' target to depend on 'install.tools', which will build gomd2man. This avoids gomd2man to be build, even though the user already request the usage of a particular gomd2man binary. It also removes an implicit build dependency on go. The latter causes downstream bugs like https://bugs.gentoo.org/931645 Signed-off-by: Florian Schmaus <flo@geekplace.eu>
|
Ephemeral COPR build failed. @containers/packit-build please check. |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 9, 2024
Apply containers/conmon#507 to avoid the 'doc' target from depending on 'install.tools' target if GOMD2MAN is set. Closes: https://bugs.gentoo.org/931645 Signed-off-by: Florian Schmaus <flow@gentoo.org>
|
LGTM. Thank you. |
saschagrunert
approved these changes
May 10, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the GOMD2MAN (environment) variable is set, then we do not need the 'docs' target to depend on 'install.tools', which will build gomd2man.
This avoids gomd2man to be build, even though the user already request the usage of a particular gomd2man binary. It also removes an implicit build dependency on go. The latter causes downstream bugs like https://bugs.gentoo.org/931645