Skip to content

HACK: storage: overlay: only unmount storage home if needed #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HACK: storage: overlay: only unmount storage home if needed #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion storage/drivers/overlay/overlay.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,11 @@ func (d *Driver) Cleanup() error {
if anyPresent {
return nil
}
return mount.Unmount(d.home)
// Ensure that we do not unmount anything not mounted by us
if !d.options.skipMountHome {
return mount.Unmount(d.home)
}
return nil
}

// pruneStagingDirectories cleans up any staging directory that was leaked.
Expand Down