common/libimage/manifests.list.Add(): add from lists without images #382
+48
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding the contents of a list to another list, keep track of the MediaType that described the list elements, so that we can handle cases where the entry being referred to is unreadable. When adding a non-list manifest to a list, default to reusing the MediaType of the non-list for its entry in the list to which it's being added. If we can't read a manifest or configuration blob from an item that we're adding to a list, don't fail if we already have the information that we would try to read from the configuration blob. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 8, 2025
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding the contents of a list to another list, keep track of the MediaType that described the list elements, so that we can handle cases where the entry being referred to is unreadable.
When adding a non-list manifest to a list, default to reusing the MediaType of the non-list for its entry in the list to which it's being added.
If we can't read a manifest or configuration blob from an item that we're adding to a list, don't fail if we already have the information that we would try to read from the configuration blob.
Fixes containers/podman#27228.