WIP: BROKEN sketch at how digest choice might work for c/image/copy
#512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This is: - UNUSABLE - INCOMPLETE (manifest digests, TryReusingBlob, ...) - BROKEN (various code assumes that digest returned from upload matches input) Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
commented
Nov 29, 2025
| // Situation records the context in which a digest is being chosen. | ||
| type Situation struct { | ||
| Preexisting digest.Digest // If not "", a pre-existing digest value (frequently one which is cheaper to use than others) | ||
| CannotChangeAlgorithm bool // If true, (Preexisting != "") and that value must not be replaced. |
Contributor
Author
There was a problem hiding this comment.
Probably …Reason string for better error messages
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Nov 29, 2025
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6552 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lsm5 I’m thinking something vaguely like this will be necessary to support #375 (comment) , depending on users’ desires:
--preserve-digests)I don’t know whether we want to expose all of these options to users, but I do think we must make the algorithm choice based on source image+
cannotModify…+user options, and this might be a possible way to structure that.Warning: c/image/copy continues to make assumptions that would be broken by changing a digest algorithm during copy. This is unusable as is. I didn’t run the code at all.