[podman-5.7] Use $BINDIR as the default helper binary directory on Windows #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default helper binary directory on Windows was hardcoded. However the new user-scope installer deploys the binaries on a distinct directory. As a consequence `podman machine start` fails because gvproxy/winssh-proxy cannot be found. This problem affects Hyper-V, not WSL. To fix the problem we are using $BINDIR that is used by the function FindHelperBinaries to look in the directory where podman is located. Fixes containers/podman#27603 Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
|
Packit jobs failed. @containers/packit-build please check. |
Luap99
changed the title
l0rd
force-pushed
the
win-default-helper-binaries-cp
branch
from
e9a3fbf to
15e67a3
Compare
Member
Author
|
@containers/container-libs-maintainers PTAL |
mtrmac
reviewed
Dec 3, 2025
Contributor
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
I know nothing other than this is an equivalent backport, but I can press green buttons :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick 4877783