linux: always use direct mapping #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Feb 20, 2023
always use the direct mapping when writing the mappings for an idmapped mount. crun was previously using the reverse mapping, which is not correct and it is being addressed here: containers/crun#1147 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
always use the direct mapping when writing the user namespace for an idmapped mount. This is a breaking change but it is a fairly recent feature and it is only Podman using it. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
reverse-idmapping
branch
from
e67b316 to
2da0773
Compare
|
the failure in I'll reenable it once a new crun that contains the current patch gets into a new Fedora build |
|
@rhatdan PTAL (and containers/podman#17577) |
|
LGTM |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Mar 25, 2023
always use the direct mapping when writing the mappings for an idmapped mount. crun was previously using the reverse mapping, which is not correct and it is being addressed here: containers/crun#1147 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit af8d649)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always use the direct mapping when writing the user namespace for an idmapped mount. This is a breaking change but it is a fairly recent feature and it is only Podman using it.