Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libocispec: update #1448

Merged
merged 1 commit into from
Apr 12, 2024
Merged

libocispec: update #1448

merged 1 commit into from
Apr 12, 2024

Conversation

Ecordonnier
Copy link
Contributor

@Ecordonnier Ecordonnier commented Apr 11, 2024 •
edited
Loading

flouthoc
flouthoc approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM,

Not a blocker at all but in case if you repush could you add the commit to which libocispec submodule points now in the PR description and commit msg.

@flouthoc
Copy link
Collaborator

@giuseppe PTAL

@giuseppe
Copy link
Member

yes, please merge the commits otherwise we would have a build failure when we use git bisect

@flouthoc
Copy link
Collaborator

@Ecordonnier Could you please squash the two commits into one, and if possible add commit id of sub-module libocispec repo in the commit.

@Ecordonnier
libocispec: update
e6a8d51 
- update libocispec to containers/libocispec@c715dcd
- rename class to _class

Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
@Ecordonnier
Copy link
Contributor Author

Ecordonnier commented Apr 12, 2024 •
edited
Loading

@Ecordonnier Could you please squash the two commits into one, and if possible add commit id of sub-module libocispec repo in the commit.

@flouthoc OK, done.

flouthoc
flouthoc approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @giuseppe PTAL

@giuseppe giuseppe merged commit 68df083 into containers:main Apr 12, 2024
52 checks passed
@Ecordonnier Ecordonnier deleted the eco/bump-libocispec branch April 12, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flouthoc flouthoc flouthoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ecordonnier @flouthoc @giuseppe