[WIP] src/libcrun: fix error handling in libcrun_kill_linux #1535
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
podman system tests failed. @containers/packit-build please check. |
sohankunkerkar
force-pushed
the
fix-ci-test
branch
from
2ba7271
to
fadb8e8
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
podman system tests failed. @containers/packit-build please check. |
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
sohankunkerkar
force-pushed
the
fix-ci-test
branch
from
fadb8e8
to
e4b4a21
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
podman system tests failed. @containers/packit-build please check. |
| @@ -5618,7 +5618,7 @@ libcrun_kill_linux (libcrun_container_status_t *status, int signal, libcrun_erro | |||
| if (errno == ENOSYS) | |||
| return libcrun_kill_linux_no_pidfd (status, true, signal, err); | |||
| if (errno == ESRCH) | |||
| return crun_make_error (err, 0, "container not running"); | |||
| return crun_make_error (err, errno, "container not running"); | |||
There was a problem hiding this comment.
This address CI failures, but is there a way to customize this?
There was a problem hiding this comment.
@giuseppe Any thoughts?
There was a problem hiding this comment.
container_delete_internal ignores ESRCH. I think there is no harm in having it in the error code
Follow-up to #1532
Addressing CI failures: https://github.com/containers/crun/actions/runs/10595280805/job/29360698730