Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug logs for container creation #1552

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Add debug logs for container creation #1552

merged 1 commit into from
Sep 6, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 5, 2024 •
edited
Loading

Demo:

> sudo ./crun --log-level=debug create ctr
2024-09-06T07:58:53.348572Z: Using debug verbosity
2024-09-06T07:58:53.348597Z: Loading container from config file: config.json
2024-09-06T07:58:53.348678Z: Using bundle: /home/sascha/git/crun
2024-09-06T07:58:53.348682Z: Creating container: ctr
2024-09-06T07:58:53.348688Z: Checking run directory: /run/crun
2024-09-06T07:58:53.348706Z: Creating exec fifo: /run/crun/ctr/exec.fifo
2024-09-06T07:58:53.348717Z: Running with prefork enabled
2024-09-06T07:58:53.348722Z: Reading config file: config.json
2024-09-06T07:58:53.348733Z: Writing config file to: /run/crun/ctr/config.json
2024-09-06T07:58:53.348745Z: Creating new keyring
2024-09-06T07:58:53.348759Z: Using cgroupfs cgroup manager
2024-09-06T07:58:53.348762Z: Using container host UID 0 and GID 0
2024-09-06T07:58:53.348898Z: Running linux container
2024-09-06T07:58:53.348901Z: Unsharing namespace: pid
2024-09-06T07:58:53.348903Z: Unsharing namespace: network
2024-09-06T07:58:53.348905Z: Unsharing namespace: ipc
2024-09-06T07:58:53.348906Z: Unsharing namespace: uts
2024-09-06T07:58:53.348908Z: Unsharing namespace: cgroup
2024-09-06T07:58:53.348910Z: Unsharing namespace: mount
2024-09-06T07:58:53.348922Z: Set rlimit: soft = 1024, hard = 1024
2024-09-06T07:58:53.349416Z: Running container on PID: 467823
2024-09-06T07:58:53.350763Z: Writing container status

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@kwilczynski
Copy link
Member

Nice!

@packit-as-a-service Packit-as-a-Service
Copy link

podman system tests failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

podman system tests failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

podman system tests failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

podman system tests failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

podman system tests failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

podman system tests failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@saschagrunert
Add debug logs for container creation
a5320ae 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert changed the title WIP: Add debug logs for container creation Add debug logs for container creation Sep 6, 2024
@saschagrunert
Copy link
Member Author

I think that's enough for the first step.

@giuseppe @rhatdan @kwilczynski PTAL

@rhatdan
Copy link
Member

rhatdan commented Sep 6, 2024

LGTM
@giuseppe PTAL

giuseppe
giuseppe approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
Copy link
Member

giuseppe commented Sep 6, 2024 •
edited
Loading

is there anything more you want to get into crun? I am planning/working to cut a new release next week as we have a lot of new cool stuff

@mohanboddu FYI

@giuseppe giuseppe merged commit b3ee99d into containers:main Sep 6, 2024
57 checks passed
@haircommander
Copy link
Contributor

there's one more bug fix I may try to tackle but don't block on it. I'll let you know if I come up with anything

@saschagrunert
Copy link
Member Author

I’d love to see #1482 fixed, but nothing speaks against a new release from my point of view.

@giuseppe
Copy link
Member

giuseppe commented Sep 6, 2024

there's one more bug fix I may try to tackle but don't block on it. I'll let you know if I come up with anything

is it tracked somewhere?

@giuseppe
Copy link
Member

giuseppe commented Sep 9, 2024

I've just released 1.17: https://github.com/containers/crun/releases/tag/1.17

@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @kwilczynski @rhatdan @giuseppe @haircommander