linux: fix creating devices in the rootfs #960
Conversation
fix the creation of devices nodes in the container rootfs. commit d583bdc introduced the regression. Closes: containers#917 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
@cdoern the podman failure seems to be related to the fact that the io limits are applied to the infra container, not the pod cgroup. Is it a known regression or how is it supposed to work (and why does the Podman CI pass? 😄) |
|
@giuseppe this is unexpected but I think I know where this is happening. My theory is that is is being applied to both infra and the pod cgroup (which is overkill and breaking this) so I just need to cut off infra from getting these assigned. |
|
I think we still miss the plumbing for the pod cgroup. At least there isn't for systemd. I have opened a PR for Podman to drop the test for now |
hm, I will look at the systemd docs: https://www.freedesktop.org/software/systemd/man/systemd.resource-control.html and see if I can find the missing values. I assumed not exposing them yet wouldn't break anything, especially if |
|
I can fold this fix into containers/common#1082 and then vendor it into podman. |
|
Merging this since PR LGTM and CI is green now. |
fix the creation of devices nodes in the container rootfs.
commit d583bdc introduced the regression.
Closes: #917
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com