Superseed #130 and #129 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful on the new M1 machines to avoid the use of rosetta. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
This makes use of github.com/randall77/makefat in order to generate a gvproxy-darwin binary containing both the amd64 and arm64 binaries. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Tests are currently failing because of an unexpected 'src 192.168.127.2' appearance in 'ip route show' output. It's likely unrelated to gvisor-tap-vsock and caused by a change in the underlying OS. This commit ignores this extra output if it's present, which fixes the tests. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Adding the `-cpu host` option to the `qemuArgs` function for darwin removes the warning message, "host doesn't support requested feature: CPUID.80000001H:ECX.svm [bit 2]" Signed-off-by: Praveen Kumar <kumarpraveen.nitdgp@gmail.com>
gbraad
approved these changes
Jul 14, 2022
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: gbraad, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This superseded #130 with #130 (comment)