-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for dynamically adding of DNS records #217
Conversation
Failed CI is due to GitHub actions downtime i think. |
Yes, after a few tries it's green :) |
As a heads-up, this conflicts with #223, not sure which one will get merged first. |
Sure 👍 Can take care of resolving conflicts if that get's merged first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, though the zones
data structure needs to be protected against concurrent accesses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though there's now a conflict. I can fix the conflict myself if you don't have time for it now.
@cfergeau - Resolving conflicts now. |
Signed-off-by: Balaji Vijayakumar <kuttibalaji.v6@gmail.com>
Signed-off-by: Balaji Vijayakumar <kuttibalaji.v6@gmail.com>
Signed-off-by: Balaji Vijayakumar <kuttibalaji.v6@gmail.com>
@cfergeau |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: balajiv113, cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #214
Note: I haven't provided delete functionality as the addition is always going to be the first searched DNS zone.
If you still feel like we need one i can provide that support as well.