Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dynamically adding of DNS records #217

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

balajiv113
Copy link
Contributor

Fixes #214

Note: I haven't provided delete functionality as the addition is always going to be the first searched DNS zone.
If you still feel like we need one i can provide that support as well.

@balajiv113
Copy link
Contributor Author

balajiv113 commented May 18, 2023

Failed CI is due to GitHub actions downtime i think.
Should get successful with a retry once

@cfergeau
Copy link
Contributor

Failed CI is due to GitHub actions downtime i think. Should get successful with a retry once

Yes, after a few tries it's green :)

@cfergeau
Copy link
Contributor

As a heads-up, this conflicts with #223, not sure which one will get merged first.

@balajiv113
Copy link
Contributor Author

Sure 👍 Can take care of resolving conflicts if that get's merged first

Copy link
Contributor

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, though the zones data structure needs to be protected against concurrent accesses.

pkg/services/dns/dns.go Outdated Show resolved Hide resolved
pkg/services/dns/dns.go Show resolved Hide resolved
Copy link
Contributor

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though there's now a conflict. I can fix the conflict myself if you don't have time for it now.

@openshift-ci openshift-ci bot added the approved label Jun 7, 2023
@balajiv113
Copy link
Contributor Author

@cfergeau - Resolving conflicts now.

Signed-off-by: Balaji Vijayakumar <kuttibalaji.v6@gmail.com>
Signed-off-by: Balaji Vijayakumar <kuttibalaji.v6@gmail.com>
Signed-off-by: Balaji Vijayakumar <kuttibalaji.v6@gmail.com>
@balajiv113
Copy link
Contributor Author

@cfergeau
Resolved conflicts.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: balajiv113, cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau cfergeau merged commit db793a5 into containers:main Jun 7, 2023
@balajiv113 balajiv113 deleted the dynamic-dns branch June 7, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for dynamic addition of DNS records
2 participants