-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packit: switch to rpm/gvisor-tap-vsock.spec #247
Conversation
Failed to load packit config file:
For more info, please check out the documentation or contact the Packit team. |
|
Is this PR still needed? I've rebased it in https://github.com/cfergeau/gvisor-tap-vsock/tree/packit-update |
I need to rebase this on main. |
@lsm5 I've already done this in https://github.com/cfergeau/gvisor-tap-vsock/tree/packit-update |
97e3fb9
to
06d1116
Compare
The centos-stream builds are failing, the centos-stream-8 builds complain about a missing 'go-rpm-macros' package, the centos-stream-9 builds complain about the aarch64/x86_64 architectures not being included(?) |
conditionalized go-rpm-macros. The c9s failure are a result of a faulty |
d9070e1
to
1e6e15b
Compare
@cfergeau PTAL |
@cfergeau once this is merged, whenever there's a new release published to github, packit will create rpm update PRs to https://src.fedoraproject.org/rpms/gvisor-tap-vsock , which will need a human to review and merge. After packit's first PR, subsequent PRs should have a minimal diff. |
This needs a small change for correct obsoletion. Updating.. |
gvisor-tap-vsock has now been included as a separate Fedora package. This commit also enables downstream Fedora packaging tasks on upstream release. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Done. |
/approve |
LGTM |
@cfergeau this is good to go. PTAL. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
gvisor-tap-vsock has now been included as a separate Fedora package.
This commit also enables downstream Fedora packaging tasks on upstream
release.