gvproxy: add docker.internal dns entries #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
force-pushed
the
gvproxy-dns-entries
branch
from
0234b22 to
28daf7b
Compare
crc does not use Apart from this, |
Luap99
force-pushed
the
gvproxy-dns-entries
branch
from
28daf7b to
79cd982
Compare
|
Good to know, I removed crc.testing. |
Some tools hard code the `host.docker.internal` dns name so it is not possible to run them with podman right now. Adding the entry is simple so we should support it for better compatibility. Also remove crc.testing, podman does not depend on it since at least v4.0 and it seems like there are no other users. see containers/podman#19361 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
force-pushed
the
gvproxy-dns-entries
branch
from
79cd982 to
49a1f88
Compare
cfergeau
approved these changes
Aug 4, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Draft
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tools hard code the
host.docker.internaldns name so it is not possible to run them with podman right now. Adding the entry is simple so we should support it for better compatibility.Also remove crc.testing, podman does not depend on it since at least v4.0 and it seems like there are no other users.
see containers/podman#19361