Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit: reuse copr targets for podman-next #267

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 7, 2023

Fedora 37 is already disabled on the podman-next copr for this package
but that setting doesn't seem to be honoured atm.

This commit reuses copr targets so builds for f37 are disabled via
packit.

Fedora 37 is already disabled on the podman-next copr for this package
but that setting doesn't seem to be honoured atm.

This commit reuses copr targets so builds for f37 are disabled via
packit.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5
Copy link
Member Author

lsm5 commented Sep 7, 2023

We'll find out if this works only after the PR is merged :|

Copy link
Contributor

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@@ -38,6 +38,7 @@ jobs:
branch: main
owner: rhcontainerbot
project: podman-next
targets: *copr_targets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great that they can be reused rather than duplicated!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 507f568 into containers:main Sep 7, 2023
5 of 15 checks passed
@lsm5 lsm5 deleted the packit-targets branch September 7, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants