Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: gvisor.dev/gvisor v0.0.0-20231023213702-2691a8f9b1cf (Support Go1.22) #311

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

AkihiroSuda
Copy link
Contributor

@AkihiroSuda AkihiroSuda commented Jan 15, 2024

This revision is compatible with Go 1.20, 1.21, and 1.22rc1.
New versions (>= v0.0.0-20231024051821-3b00acd67af2) are no longer compatible with Go 1.20.

Fixes #310

This revision is compatible with Go 1.20, 1.21, and 1.22rc1.

v0.0.0-20231024051821-3b00acd67af2 is no longer compatible with Go 1.20.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@cfergeau
Copy link
Contributor

This revision is compatible with Go 1.20, 1.21, and 1.22rc1.
New versions (>= v0.0.0-20231024051821-3b00acd67af2) are no longer compatible with Go 1.20.

Thanks for the tests with multiple go versions! I hope 1.22 final version will also work with this gvisor version to avoid the situation we were in for the 1.21 release

@cfergeau
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4d95585 into containers:main Jan 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't compile with Go 1.22rc1: undefined: goready, ...
2 participants