Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consistent udp packet loss after the proxy read loop stopped #393

Merged
merged 1 commit into from
Sep 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix consistent udp packet loss after the proxy read loop stopped
Signed-off-by: Fata Nugraha <fatanugraha@outlook.com>
fatanugraha authored and cfergeau committed Sep 18, 2024
commit cdb2efaabc09923b8edbbd5e08d65a7e7049c9ba
9 changes: 8 additions & 1 deletion pkg/services/forwarder/udp.go
Original file line number Diff line number Diff line change
@@ -38,6 +38,13 @@ func UDP(s *stack.Stack, nat map[tcpip.Address]tcpip.Address, natLock *sync.Mute
p, _ := NewUDPProxy(&autoStoppingListener{underlying: gonet.NewUDPConn(s, &wq, ep)}, func() (net.Conn, error) {
return net.Dial("udp", fmt.Sprintf("%s:%d", localAddress, r.ID().LocalPort))
})
go p.Run()
go func() {
p.Run()

// note that at this point packets that are sent to the current forwarder session
// will be dropped. We will start processing the packets again when we get a new
// forwarder request.
ep.Close()
}()
})
}