Skip to content

Commit

Permalink
Add a note about (unsquashfs -o)
Browse files Browse the repository at this point in the history
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
  • Loading branch information
mtrmac committed Jan 10, 2022
1 parent 55df551 commit 4f38711
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions sif/load.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ func convertSIFToElements(ctx context.Context, sifImage *sif.FileImage, tempDir
if err != nil {
return "", nil, fmt.Errorf("looking up rootfs from SIF file: %w", err)
}
// TODO: We'd prefer not to make a full copy of the file here; unsquashfs ≥ 4.4
// has an -o option that allows extracting a squashfs from the SIF file directly,
// but that version is not currently available in RHEL 8.
if err := func() error { // A scope for defer
f, err := os.Create(squashFSPath)
if err != nil {
Expand Down

0 comments on commit 4f38711

Please sign in to comment.