Skip to content

Commit

Permalink
FIXME FIXME: Add FIXMEs
Browse files Browse the repository at this point in the history
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
  • Loading branch information
mtrmac committed Jun 13, 2022
1 parent fb44c02 commit ff8971d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions copy/copy.go
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,7 @@ func (c *copier) copyOneImage(ctx context.Context, policyContext *signature.Poli
// that the compressed version coming from a third party may be designed to attack some other decompressor implementation,
// and we would reuse and sign it.
// - Finally, let the image format handler influence this (in particular to disable substitution for OCI artifacts).
// FIXME: More debug logs about this decision?
ic.canSubstituteBlobs = ic.cannotModifyManifestReason == "" && options.SignBy == "" && ic.src.CanSubstituteLayers()

if err := ic.updateEmbeddedDockerReference(); err != nil {
Expand Down Expand Up @@ -1413,6 +1414,7 @@ func (ic *imageCopier) copyBlobFromStream(ctx context.Context, srcStream io.Read
canModifyBlob := !isConfig && ic.cannotModifyManifestReason == ""
// === Deal with layer compression/decompression if necessary
layerCompressionChangeSupported := ic.src.CanChangeLayerCompression(srcInfo.MediaType)
// FIXME: More debug logs about this decision?
canChangeCompression := canModifyBlob && layerCompressionChangeSupported
compressionMetadata := map[string]string{}
var inputInfo types.BlobInfo
Expand Down

0 comments on commit ff8971d

Please sign in to comment.