Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copies don’t set OCI1InstanceAnnotationCompressionZSTD on Zstd:chunked #2077

Closed
mtrmac opened this issue Aug 4, 2023 · 1 comment · Fixed by #2302
Closed

Copies don’t set OCI1InstanceAnnotationCompressionZSTD on Zstd:chunked #2077

mtrmac opened this issue Aug 4, 2023 · 1 comment · Fixed by #2302
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Aug 4, 2023

addCompressionAnnotations needs to also recognize Zstd:chunked.

That probably involves actually writing down what InternalUnstableUndocumentedMIMEQuestionMark means, 2 years after lazily deciding to use that name instead of figuring it out.

Cc: @flouthoc
@mtrmac mtrmac added the kind/bug A defect in an existing functionality (or a PR fixing it) label Aug 4, 2023
@flouthoc
Copy link
Contributor

flouthoc commented Aug 5, 2023

/assign

@mtrmac mtrmac mentioned this issue Nov 13, 2023
Open
36 tasks
mtrmac added a commit to mtrmac/image that referenced this issue Feb 20, 2024
@mtrmac
Also annotate image instances using zstd:chunked as using zstd
060c08f 
... so that zstd-preferring implementations like c/image can
choose them.

Fixes containers#2077.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac mentioned this issue Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Also annotate image instances using zstd:chunked as using zstd mtrmac/image
2 participants
@mtrmac @flouthoc