Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to realpath() on /proc/$pid/fd magic links #1208

Closed
wants to merge 1 commit into from
Closed

Don't try to realpath() on /proc/$pid/fd magic links #1208

wants to merge 1 commit into from

Commits on Apr 22, 2021

  1. Don't try to realpath() on /proc/$pid/fd magic links 

    I'm trying to do `skopeo copy docker://quay.io/cgwalters/fcos oci-archive://proc/self/fd/5`
where a higher level process passes the write end of a `pipe()`.

We can't call `realpath` on a pipe, and actually in general I think
programs should avoid running `realpath` and just operate on what
they're passed directly.  There is presumably some reason
we're doing this but it seems like it should work to pass
a pipe, so let's not error out.
    @cgwalters
    cgwalters committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    46ac89f View commit details
    Browse the repository at this point in the history