build(deps): bump github.com/vbauerster/mpb/v7 from 7.3.2 to 7.4.1 #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
mtrmac
requested changes
Feb 22, 2022
There was a problem hiding this comment.
DO NOT just merge this.
vbauerster/mpb@5e2ae42 and vbauerster/mpb@226d553 has changed behavior, so it is necessary to review which of our SetTotal calls are necessary/effective, and possibly replace them.
I.e. some version of #1464 .
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1
branch
3 times, most recently
from
1237591 to
d6bc361
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1
branch
5 times, most recently
from
ca8b825 to
82968e0
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1
branch
4 times, most recently
from
9ca123d to
32d24d1
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1
branch
2 times, most recently
from
50cb7f4 to
8baa163
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1
branch
2 times, most recently
from
bae20ee to
e207603
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1
branch
2 times, most recently
from
f174831 to
88429c5
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1
branch
from
88429c5 to
60da75f
Compare
Bumps [github.com/vbauerster/mpb/v7](https://github.com/vbauerster/mpb) from 7.3.2 to 7.4.1. - [Release notes](https://github.com/vbauerster/mpb/releases) - [Commits](vbauerster/mpb@v7.3.2...v7.4.1) --- updated-dependencies: - dependency-name: github.com/vbauerster/mpb/v7 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1
branch
from
60da75f to
4abb763
Compare
|
@mtrmac Did you ever get a chance to review? |
|
It’s not just a review, it’s code changes we need to make. I suppose it’s not something I can justify deferring any longer… |
|
Looks like github.com/vbauerster/mpb/v7 is up-to-date now, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/vbauerster/mpb/v7 from 7.3.2 to 7.4.1.
Release notes
Sourced from github.com/vbauerster/mpb/v7's releases.
Commits
90fc0dev7.4.1b39842ccheck if bar is running with single callc51c704SetTotal godoc upd71608c0EnableTriggerComplete only after total has been set5c39c42v7.4.08ac91f4return early if s.aborted0e80546refactoring proxyreader_test85a05e7prefer public api8d4ace4better var namef239b65prefer public apiDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)