Don't require a Docker-Content-Digest header when deleting images #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
delete-compute-digest
branch
2 times, most recently
from
7d304fa to
c1520e2
Compare
|
#1010 (comment) confirms this PR works as intended. Sadly it doesn’t ultimately make a difference; still, I think it’s worthwhile to make this code path more similar to the much-more-frequently-used ones. |
mtrmac
changed the title
mtrmac
force-pushed
the
delete-compute-digest
branch
from
c1520e2 to
377c319
Compare
Per containers#1010 , it seems the header is not populated by AWS ECR. We were actually computing the digest from the manifest bytes already, so this is both more robust and simpler. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
delete-compute-digest
branch
from
377c319 to
15e689d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1010 , it seems the header is not populated by AWS ECR.
We were actually computing the digest from the manifest bytes already, so this is both more robust and simpler.
WIP: Untested manually (there is a system test forskopeo deletethat will exercise this), and we should get a confirmation that this fixes #1010 .