Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use c/storage/pkg/ioutils.AtomicWriteFiles to update auth.json #1515

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Apr 4, 2022

... so that users can't observe an intermediate empty, or partial, file.

(Note that there is still no locking, so two simultaneous updates to auth.json might lose some updates.)

Fixes at least the worst impact of #1365 .

... so that users can't observe an intermediate empty, or partial, file.

(Note that there is still no locking, so two simultaneous updates to
auth.json might lose some updates.)

Fixes at least the worst impact of containers#1365 .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Collaborator Author

mtrmac commented Apr 4, 2022

c/image/storage already depends on c/storage/pkg/ioutils, so for those users this is not a new dependency. Even pure users of c/image/storage should only need to depend on a few very small sub packages more.

@rhatdan
Copy link
Member

rhatdan commented Apr 4, 2022

LGTM
@vrothberg PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 57996f8 into containers:main Apr 5, 2022
@mtrmac mtrmac deleted the atomic-auth.json branch April 5, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants