-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/containers/ocicrypt to 566b808 #1534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I don’t think Dependabot is bringing in commits that aren’t a tagged release, at least in our configuration.)
LGTM. (This changes default behavior on encryption, but at least from the diff, no changes were necessary on the recipient side, so the new behavior should still be interoperable with older consumers.)
Thanks!
@cevich Does c/image need something like containers/skopeo#1631 ? |
Yep, exactly. #1535 |
The two latest commits in c/ocicrypt get rid of OAEPDefaultHash envvar and default to sha256. They are waiting for confirmation on their rust side before cutting a release. So, hoping to get this in assuming dependabot could take a while. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2365e91
to
ee9ce71
Compare
@mtrmac should be good to go now. |
@mtrmac is this worth a new version for dependabot's sake, or would you be cool if I vendor the commit into our usual tools? No rush of course, enjoy your weekend :) |
… WRT vendoring by commit, the code should be in good enough shape to do that if you want to e.g. benefit from it even in advance of that vendor dance. |
I'm cool with waiting, thanks a lot @mtrmac |
The two latest commits in c/ocicrypt get rid of OAEPDefaultHash envvar
and default to sha256.
They are waiting for confirmation on their rust side before cutting a
release. So, hoping to get this in assuming dependabot could take a
while.
Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org
@mtrmac @vrothberg @rhatdan PTAL.