Update to golangci-lint 1.51.0 #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
golangci-lint
branch
4 times, most recently
from
207e216 to
261c33b
Compare
This is required for support of Go 1.20. Also avoid a call to math/rand.Read, which is deprecated in Go 1.20. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: bodyclose Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: dupword Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: errorlint Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: forbidigo Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: gci Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: gocritic Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: gocritic Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: gocritic Don't use the "linter control" format without a leading space Use a correct Deprecated: comment Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: godot Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: golint Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: golint Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: golint Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: golint Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: prealloc Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: unparam Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: unparam Signed-off-by: Miloslav Trmač <mitr@redhat.com>
golangci-lint linter: whitespace Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
Rebased. Merging immediately so that Apologies for the churn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for support of Go 1.20.
Also avoid a call to math/rand.Read, which is deprecated in Go 1.20.
Then, manually enable all linters, and fix up things that seem either relevant, or easier to fix than to check again.