Remove a direct use of golang.org/x/net/http2 #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
A version of golang.org/x/net/http2 is bundled into the standard library: https://github.com/golang/go/blob/master/src/net/http/h2_bundle.go and here we certainly don't care about the specific version or details. So just enable use of the built-in one. Note that this is very unlikely to actually remove the dependency from binaries, because it is required by google.golang.org/grpc/internal/transport, and that one has quite a few uses; so most of the benefit right now is just one less package to get dependency update PRs from. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A version of
golang.org/x/net/http2is bundled into the standard library: https://github.com/golang/go/blob/master/src/net/http/h2_bundle.go and here we certainly don't care about the specific version or details.So just enable use of the built-in one.
Note that this is very unlikely to actually remove the dependency from binaries, because it is required by
google.golang.org/grpc/internal/transport, and that one has quite a few uses; so most of the benefit right now is justone less package to get dependency update PRs from.
Also replace deprecated
DialbyDialContext.