Relax retry heuristics #1847

mtrmac · 2023-02-13T18:52:05Z

Even if we didn't make much progress, allow one retry per minute anyway. Notably this allows one retry ~immediately, we see failures a few dozen milliseconds after the connection is set up.

Purely aesthetic, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

... because we will have more cases of the NaN case, so share that code path. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Avoid redundant work. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Consistently use ms... for milliseconds (durations), and ...Time for timestamps. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

This will be used for more heuristics. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

mtrmac · 2023-02-13T18:52:53Z

Untested in practice; I’ll at least open a Podman PR to have a chance to notice stupid crashes.

I should also add unit tests…

mtrmac · 2023-02-13T19:00:03Z

Podman PR: containers/podman#17492

Even if we didn't make much progress, allow one retry per minute anyway. Notably this allows one retry ~immediately, we see failures a few dozen milliseconds after the connection is set up. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

…d offset Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Signed-off-by: Miloslav Trmač <mitr@redhat.com>

mtrmac · 2023-02-13T21:35:06Z

Some unit tests added — for the heuristics, not for the retry implementation itself. (The Read implementation has been exercised and is not changing in this PR, so there’s less risk to it.)

rhatdan · 2023-02-14T03:32:57Z

docker/body_reader.go

+	// bodyReaderMinimumProgress is the minimum progress we consider a good reason to retry
+	bodyReaderMinimumProgress = 1 * 1024 * 1024
+	// bodyReaderMSSinceLastRetry is the minimum time since a last retry we consider a good reason to retry
+	bodyReaderMSSinceLastRetry = 60 * 1_000


I did not know about the _ support in 1_000, cool.

rhatdan · 2023-02-14T03:33:56Z

LGTM

vrothberg

LGTM

... for Podman to immediately benefit from the updated heuristic. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

@ygalblum

Aditya R (9): remote,build: error if containerignore is symlink docs: specify order preference for FROM vendor: bump buildah to v1.29.1-0.20230201192322-e56eb25575c7 system-reset: use CleanCacheMount to clear build cache volume,container: chroot to source before exporting content vendor: bump containers/(storage, common, buildah, image) test/system: expect 12 char for short id test: retrofit error message build: pass env by reference Adrian Reber (2): Update checkpointctl v0.1.0 Use append() to add elements to a slice Alex Jia (2): Fix typos in comments test: podman checkpoint/restore the latest container Alex Willmer (1): docs: minor grammar fix in `--volume` description Alexander Gryanko (1): The `--ulimit` option accepts the name with an `RLIMIT_` prefix both upper and lower case Alexis Couvreur (1): docs: add `starting` to `HealthCheckResults.Status` Anjan Nath (1): pkginstaller: bump Qemu to version 7.2.0 Arthur Sengileyev (5): Add gvproxy to Windows packages Making gvproxy.exe optional for building Windows installer Support for Windows paths in the source position of the volume mounts Expose Podman named pipe in Inspect output Document building Podman remote on Windows hosts Ashley Cui (7): Update main to reflect v4.4.0 release Bump to v4.5.0-dev Introduce podman machine os apply Update release notes from 4.4 branch Bump to 4.5.0-rc1 Bump to v4.5.0-dev [CI:DOCS] Release notes for 4.5.0 Part 1 Brent Baude (7): WSL refactoring machine refactoring preparations for hyperv machine refactoring preparations for hyperv Machine refactor for QEMU/AppleHV basic hypverv machine implementation hyperv: lookup machine on local filesystem first implement podman machine set for hyperv Cedric Staniewski (2): quadlet: implement `Tmpfs` option quadlet: add `UserNS` option key Chris Evich (27): Cirrus: Use versionable IMAGE_SUFFIX Cirrus: Emergency fix to un-stuck PRs Revert "Cirrus: Emergency fix to un-stuck PRs" [CI:BUILD] Cirrus: Fix GraphQL ownerRepository:null error Cirrus: Omit functions in env. file Cirrus: Make benchmarks .env file easier to load CI: Temporarily disable all AWS EC2-based tasks Cirrus: Fix version-check to only run on `main` job Revert "CI: Temporarily disable all AWS EC2-based tasks" [CI:DOCS] Windows/Mac docs link update Makefile: Define SHELL Skip rootless CGv1 quadlet tests due to issue Skip tests which fail with CGv1 & runc Skip 'podman kube --network' test for rootless CGv1 Skip buildx test with VFS podman storage driver Skip buildah-bud test Skip all pasta tests Cirrus: Support runc testing on debian VMs Temporarily disable version-check Cirrus: Fix bud tests failing to apply patches Cirrus: Fix git config permission denied [CI:DOCS] Fix docs/version-check always requesting updates Cirrus: Run system & integration tests in parallel Cirrus: Store podman machine benchmark data Cirrus: Fix aarch64 clone_script 404 errors Cirrus: Enable labeling of EC2 VMs GHA: Use version instead of SHA for actions Claudio Nave (1): #17363 Fix contradicting documentation podman-commit Dan Čermák (1): Clarify that replicas are ignored in kubernetes deployment Daniel J Walsh (34): Allow --device-cgroup-rule to be passed in by docker API Handle filetype field in kubernetes.yaml files Install podman-systemd.unit man page, make quadlet discoverable Cleanup podman-systemd.unit file Add quadlet support for rootfs= containers Add SELinux label types support to quadlet Sort quadlet keys to make it easier to read [CI:DOCS] Add tables to podman-systemd.unit man page [CI:DOCS] Cleanup some man pages to display options with line breaks Run codespell on codebase Quadlet use crun specified in containers.conf Allow specification of podman --remote build -f - Vendor in latest containers/storage Vendor in latest containers/(common, storage, image) podman inspect list network when using --net=host or none Must use mountlabel when creating builtin volumes Support running nested SELinux container separation Add format table to podman image inspect man page Add format to podman machine info Add format to podman system df Add format to podman secret ls Add format to podman volume inspect Add format to podman volume ls Add information for secret inspect Vendor in latest containers/(storage, common, image) Use default_ulimits field in containers.conf Add support for oom_score_adj value from containers.conf Fix option --opts -> --opt Run make codespell Update docs/source/markdown/podman-network.1.md Add support for cgroup_config from containers.conf Capitalize all uid,gid and id words that are not options in docs Fix up codespell errors Return title fields as a list Daniel Lublin (1): fix: don't output "ago" when container is currently up and running Dmitry Wagin (1): podman image scp: added identity for ssh.Exec Doug Rabson (1): libpod: avoid nil pointer dereference in (*Container).Cleanup Ed Santiago (32): e2e tests: fix incorrect os.User.Name system tests: minor fix for RHEL8 incompatibility make hack/markdown-preprocess parallel-safe [CI:DOCS] man-page checker: include --format (Go templates) events + container inspect test: RHEL fixes man page xref: validate displayed man page names man page --format xref: tighten the autocompletion check system tests: prevent leading tabs Experimental workaround for cdn03.quay.io flake quadlet system tests: add useful defaults, logging System tests: assert(): friendlier failure messages Emergency fix for man pages: check for broken includes make docs: sanity check for broken man pages Logs follow-until tests: loosen checks CI: new rootless buildah-bud tests (cron only) buildah-bud tests: don't sudo when rootless is desired bud tests: rootless remote: use correct socket path buildah treadmill: also run rootless tests logformatter: futureproof output filename CI: test and confirm DESIRED_DATABASE logformatter: hide --db-backend, and friendlyize quadlet New ulimit test: bump up minimum nfiles quadlet tests: skip on RHEL8 rootless system tests: fix racey sdnotify test CI: retry the golangci install system tests: use CONTAINERS_CONF_OVERRIDE System tests: unverbosify a flake log e2e: healthcheck on stopped container: fix flake e2e: GinkgoParallelNode() -> ...Process() e2e tests: fix racy flakes CI: postbuild step: skip under nightly treadmill Debian setup: workaround for runc /dev/char/10:200 bug Eng Zer Jun (1): chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` Erik Sjölund (3): Add missing return after errors Fix typos. Improve language. Fix typos Fabian Holler (1): Match VT device paths to be blocked from mounting exactly Giuseppe Scrivano (18): vendor: update containers/storage libpod: use GraphRoot for overlay upper dir utils: new conversion method test: adapt test to work on cgroupv1 libpod: support idmap for --rootfs libpod: allow userns=keep-id for root oci: bind mount /sys with --userns=(auto|pod:) libpod: support relative positions for idmaps libpod: always use direct mapping system: add warning when running rootless on cgroupv1 cmd: clarify meaning of ParentNSRequired cmd: drop special handling for "scp" cmd: do not require userns for "version" test: reenable idmap test libpod: remove error stutter cgroupns: private cgroupns on cgroupv1 breaks --systemd rootless: drop preexec hook error message libpod: mount safely subpaths Heniker (1): docs: fix cmd `set DOCKER_HOST` suggestion Ingo Becker (1): quadlet: Add device support for .volume files Jack Wearden (1): Makefile: allow specifying /lib dir location Jason T. Greene (7): Fix default handling of pids-limit Fix usage of absolute windows paths with --image-path Add comment to clarify error handling intention Fix package restore Fix Win install task failures with large PR bodies Don't error when removing non-existant env vars Use atomic config writing strategy for podman machine config files Jordan Christiansen (1): podman machine: Adjust Chrony makestep config Julio C. Galindo (1): Update podman-for-windows.md Lokesh Mandvekar (7): Bump cirrus image with easier dependency management [CI:BUILD] copr: podman.spec.rpkg cleanups [CI:BUILD] spec.rpkg: trim dependency list podman.spec.rpkg: distro conditionals for modulesloaddir Copr: fix build deps for /usr/bin/envsubst [CI:DOCS] Final release notes for v4.5.0 Release v4.5.0 Marek Czernek (1): fix: Document removing anonymous volumes Martin Roukala (né Peres) (1): Do not mount /dev/tty into rootless containers Matt Heon (23): Fix a potential UID/GID collision in unit tests Add initial SQLite-backed state implementation Remove concept of Namespaces from BoltDB Some further work on SQLite state Fix various lint issues Implement Network Connect/Modify for SQLite state Implement network disconnect for SQLite state Get E2E tests to pass Remove `--namespace` flag from Podman root Various fixes from code review Implement exec session handling in SQL database Add support for volume operations to SQLite state Add support for containers.conf database setting Fix an incorrect comment on NewSqliteState Add SQLite job to CI Improve handling of existing container names in SQLite Remove test for pod/container name global uniqueness Fix various integration test issues with SQLite state Ensure SQLite places uses the runroot in transient mode Update Cirrus display names, and fix get-ci-vm script Fix a race around SQLite DB config validation Ensure that SQLite state handles name-ID collisions Add remaining release notes for v4.5.0-RC2 Matthew Heon (6): Fix SQLite DB schema migration code Fix database locked errors with SQLite Drop SQLite max connections Final release notes for v4.5.0-RC2 Bump to v4.5.0-RC2 Bump to v4.5.0-dev Michael Milton (1): Edit the docker wrapper to use the install prefix Miloslav Trmač (5): Add (podman {image,manifest} push --sign-by-sigstore=param-file.yaml) Log data that we failed to unmarshal Update from /github.com/vbauerster/mpb/v7 to /v8 Vendor c/image after containers/image#1816 Vendor c/image after containers/image#1847 Nalin Dahyabhai (2): libpod.storageService.CreateContainerStorage(): retrieve ID maps "podman pull by digest and list --all" test: untag instead of rmi Nathan Henrie (1): Resolve symlink path for qemu directory if possible Paul Holzinger (30): journald: podman events only show events for current user journald: podman logs only show logs for current user update golangci-lint to version 1.51.1 golangci-lint: show all errors at once github: remove prefix from bugs/features journald: remove initializeJournal() podman logs: read journald with passthrough journald logs: simplify entry parsing podman logs passthrough driver support --cgroups=split netavark: only use aardvark ip as nameserver compat API: network create return 409 for duplicate fix "podman logs --since --follow" flake test/system: fix wait_for_port() to wait for bind system service --log-level=trace: support hijack podman-mac-helper: exit 1 on error stats compat API: return "id" lowercase podman-mac-helper: install: do not error if already installed macos pkginstaller: do not fail when podman-mac-helper fails fix os.IsNotExist() CI check fix slirp4netns resolv.conf ip with a userns test/e2e: gpg keep stdout/err attached rootless netns: recover from invalid netns update completion scripts for cobra v1.7.0 test/e2e: use custom network config dir where needed rootless: make sure we only use a single pause process pkg/rootless: use catatonit from /usr/libexec/podman network create: add --interface-name docs: update podman-network-create.1 test/e2e: deduplicated network test test/e2e: remove unnecessary SkipIfNetavark() calls Rahil Bhimjiani (1): Fix spacing typo that triggered OCD & indent units in podman-systemd.unit(5) Stefano Brivio (9): pasta: Use two connections instead of three in TCP range forward tests pasta: Fix ICMP Echo Request (IPv4) test pasta: Fix ICMPv6 Echo test, skip it for the moment CI: Switch to c20230223t153813z-f37f36d12 images Revert "Skip all pasta tests" CI: Switch to c20230307t192532z-f37f36d12 images pasta: Re-enable "Local forwarder, IPv4" test, accept NXDOMAIN as response Revert "pasta: Use two connections instead of three in TCP range forward tests" Revert "Revert "pasta: Use two connections instead of three in TCP range forward tests"" T K Chandra Hasan (2): Support sysctl configs via podman kube play Doc update for docker network options via CLI Timothée Ravier (2): docs/podman-systemd.unit: Update example to work out of the box docs/podman-systemd.unit: Explicitely mention network & kube units Toshiki Sonoda (11): e2e: reduce dependency on /tmp for e2e tests e2e: Remove some directories at SynchronizedAfterSuite e2e: Remove the cache with "podman unshare rm" when a rootless user e2e: Avoid hard-coding ImageCacheDir e2e: Avoid hard-coding included in quadlet test e2e: fix run_staticip_test about no_proxy system tests: fix volume exec/noexec test system tests: fix noexistent labels test in the remote e2e: adapt play kube test on remote rootless e2e: fix some tests on remote Add search --cert-dir, --creds Urvashi Mohnani (12): Set runAsNonRoot=true in gen kube Add ctrName to network alias during kube play Add ulimit annotation to kube gen & play Don't set hostPort when generating a service play kube: Add --wait option Add service ctr cleanup to PlayKubeDown Add debug to --wait test Use secret.items to create volume mounts if present Support Deployment generation with kube generate Fix invalid pod name and hostname during kube generate Properly remove the service container during kube down Read kube_generate_type from containers.conf Vaclav Pavlin (1): Fix user socket path Valentin Rothberg (73): ps: do not sync container DB: make loading container states optional fix CI: test fail due to merge [DOCS:CI] podman-events: document verbose create events container rm: save once for exec removal and state change [CI:DOCS] hack/perf: add script for BZ 216111 hack/perf/bz-2162111.sh: measure stop hack/perf/bz-2162111.sh: use custom network hack/perf: cleanup after benchmarks network ls: handle removed container Quadlet: exit 0 when there are no files to process [CI:DOCS] events: document journald identifiers kube play: do not teardown unconditionally on error [CI:DOCS] OWNERS: add @ygalblum and @alexlarsson kube play: set service container as main PID when possible install sigproxy before start/attach quadlet: add ExecStop auto-update: support pods kube play: only enforce passthrough in Quadlet vendor c/common@852ca05a1fbb sqlite: implement pod methods sqlite: move migration after table creation sqlite: AllContainers: fix inner join sqlite: fix typo when removing exec sessions sqlite: exit code: allow -1 sqlite: SaveVolume: fix syntax error updating the volumes table sqlite: fix "UPDATE TABLE" typos sqlite: fix AllContainers with state sqlite: AddContainerExitCode: allow to replace sqlite: LookupContainer: update error message sqlite: fix pod create/rm sqlite: fix LookupPod sqlite: fix container lookups with partial IDs sqlite: fix volume lookups with partial names auto-update test: wait for service to be ready test/system/255-auto-update.bats: wait 10 for update to finish sqlite: RewritePodConfig: update error message sqlite: return correct error on pod-name conflict sqlite: fix type rewriting container config sqlite: LookupVolume: wrap error sqlite: LookupVolume: fix partial name match sqlite: implement RewriteVolumeConfig sqlite: addContainer: add named volume only once sqlite: remove dead code sqlite: add container short ID to network aliases sqlite: add a hidden --db-backend flag compat: /auth: parse server address correctly 255-auto-update.bats: turn off rollback where needed test/system/255-auto-update.bats: multiple services podman events: unhide --stream events: no duplicates when streaming during a log rotation auto update: return restart error test/system/255-auto-update.bats: add debug logs fix --health-on-failure=restart in transient unit sqlite: set connection attributes on open sqlite: do not use shared cache vendor containers/common@main add CONTAINERS_CONF_OVERRIDE sqlite: do not `Ping()` after connecting auto-update: stop+start instead of restart sytemd units fix volume-plugin-test flake vendor containers/common@e27c30ee9b1b speed up image listing [CI:DOCS] fix typo in --systemd option quadlet: use `Flag` suffix for variables add version/rawversion package add `quadlet -version` flag rm `hack/release.sh` system service: do not close Body test/apiv2/80-kube.at test/apiv2/80-kube.at [CI:DOCS] --creds and registries test/system/252-quadlet.bats: fix flake Ygal Blum (16): Quadlet: Add support for the Secret key in Container group Quadlet: Add support for LogDriver key in container and kube units Apply suggestions to man page Quadlet - use the default runtime Quadlet: Add support for the Mount key in .container files Quadlet - Add support for health checks configuration in .container files Quadlet Doc: Suggest the kill operation for HealthOnFailure Quadlet - add support for relative path in Volume key in .container file Kube Play Doc: Document the support for K8S Secret Update docs/source/markdown/podman-kube-play.1.md.in Quadlet - treat paths starting with systemd specifiers as absolute Quadlet E2E test - run quadlet as user generator Quadlet: add support for keep-id with mapping values Quadlet: RemapUsers documentation fixes Add support for secret exists Quadlet - do not set log-driver by default danishprakash (4): kube-play: add support for HostIPC in pod.Spec add support for limiting tmpfs size for systemd-specific mnts create: add support for --group-entry kube: rm secret on down, print secret on play dependabot[bot] (28): build(deps): bump go.etcd.io/bbolt from 1.3.6 to 1.3.7 build(deps): bump github.com/vbauerster/mpb/v8 from 8.1.4 to 8.1.6 build(deps): bump golang.org/x/term from 0.4.0 to 0.5.0 build(deps): bump golang.org/x/tools from 0.5.0 to 0.6.0 in /test/tools build(deps): bump golang.org/x/text from 0.6.0 to 0.7.0 build(deps): bump golang.org/x/net from 0.6.0 to 0.7.0 build(deps): bump github.com/containerd/containerd from 1.6.16 to 1.6.18 build(deps): bump github.com/onsi/gomega from 1.26.0 to 1.27.0 build(deps): bump github.com/onsi/gomega from 1.27.0 to 1.27.1 build(deps): bump github.com/vbauerster/mpb/v8 from 8.1.6 to 8.2.0 build(deps): bump github.com/container-orchestrated-devices/container-device-interface build(deps): bump github.com/coreos/stream-metadata-go build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2 build(deps): bump github.com/onsi/gomega from 1.27.1 to 1.27.2 build(deps): bump golang.org/x/sys from 0.5.0 to 0.6.0 build(deps): bump golang.org/x/net from 0.7.0 to 0.8.0 build(deps): bump golang.org/x/tools from 0.6.0 to 0.7.0 in /test/tools build(deps): bump google.golang.org/protobuf from 1.28.1 to 1.29.0 build(deps): bump github.com/vbauerster/mpb/v8 from 8.2.1 to 8.3.0 build(deps): bump github.com/vbatts/git-validation in /test/tools build(deps): bump google.golang.org/protobuf from 1.29.0 to 1.30.0 build(deps): bump github.com/openshift/imagebuilder build(deps): bump github.com/onsi/gomega from 1.27.4 to 1.27.5 build(deps): bump github.com/onsi/gomega from 1.27.5 to 1.27.6 build(deps): bump golang.org/x/sys from 0.6.0 to 0.7.0 build(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0 build(deps): bump golang.org/x/text from 0.8.0 to 0.9.0 build(deps): bump golang.org/x/tools from 0.7.0 to 0.8.0 in /test/tools lioutall (1): Update remote_client.md nabbisen (1): fix #17244: use /etc/timezone where `timedatectl` is missing on Linux renovate[bot] (6): Add renovate.json configuration [skip-ci] Update github/issue-labeler action to v2.6 [skip-ci] Update actions/setup-go action to v4 [skip-ci] Update actions/stale action to v8 [skip-ci] Update actions/upload-artifact action to v3 chore(deps): update dependency containers/automation_images to v20230405 restitux (1): Quadlet: add support for setting --ip and --ip6 salevdns (2): Update bug_report.yaml [CI:DOCS] Clarify nomap constrains shblue21 (1): fix: running check error when podman is default in wsl telday (1): Fixes port collision issue on use of --publish-all tomsweeneyredhat (6): Bump Bulidah to v1.29.0 Clean up more language for inclusiveness [CI:DOCS] Add restriction to option README [CI:DOCS] Add image not found info to troubleshooting [CI:DOCS] Add network subnets info to network man page [CI:DOCS] Improve basic tutorial vyasgun (3): fix != filter in volume prune docs: context is not optional for build fix: update the default machine value when the previously set default machine is deleted xxyzz (1): Move clean-binaries before podman-remote in podman-remote-docs target

@ygalblum

This version introduces envsubt in the install stage, so we add gettext-native to our build dependencies. Bumping libpod to version v4.5.0-14-gc926b12c5, which comprises the following commits: bc2f0115d [v4.5] system tests: fix race in kube-play read-only 696c2d40d api: fix parsing filters 1fa2eb53b Support systemd optional prefix '-' for devices. 74634a46c *: migrate image registry to registry.k8s.io 0fb11cccd Makefile: include `release-artifacts` target 4d2cf293e [CI:BUILD] Packit: Initial Enablement da927a75c Bump to v4.5.1-dev 75e3c1257 Release v4.5.0 32a6892b6 [CI:DOCS] Final release notes for v4.5.0 5de2a13e0 Quadlet - do not set log-driver by default c5e704c82 Return title fields as a list bf6f58b02 Bump to v4.5.0-dev f3c365887 Bump to v4.5.0-RC2 15c302533 Final release notes for v4.5.0-RC2 af7c25811 test/e2e: remove unnecessary SkipIfNetavark() calls 80652cacf test/e2e: deduplicated network test b526839a4 docs: update podman-network-create.1 ed99a979c network create: add --interface-name 676486a85 test/system/252-quadlet.bats: fix flake 1bf5bdc68 Read kube_generate_type from containers.conf 11ac0d03e Debian setup: workaround for runc /dev/char/10:200 bug 38c217a0b pkg/rootless: use catatonit from /usr/libexec/podman bab95de9a rootless: make sure we only use a single pause process 3b2b1441e Use atomic config writing strategy for podman machine config files 67307603b Add remaining release notes for v4.5.0-RC2 d53871cf1 GHA: Use version instead of SHA for actions 25bc7d161 chore(deps): update dependency containers/automation_images to v20230405 944accffa build: pass env by reference 7edf73dfd test: retrofit error message b624ad757 test/system: expect 12 char for short id 260bc3ec4 vendor: bump containers/(storage, common, buildah, image) c5a0d8646 [skip-ci] Update actions/upload-artifact action to v3 d3cf8ccf8 [skip-ci] Update actions/stale action to v8 21fbd5c1a [skip-ci] Update actions/setup-go action to v4 f3971e412 [skip-ci] Update github/issue-labeler action to v2.6 c4e79fc16 Fix up codespell errors a5dd5c20e Capitalize all uid,gid and id words that are not options in docs 352a41e3a build(deps): bump golang.org/x/tools from 0.7.0 to 0.8.0 in /test/tools 13135f924 Properly remove the service container during kube down f6a50311c quadlet: add `UserNS` option key 29aac4dfe [CI:DOCS] Release notes for 4.5.0 Part 1 358b46225 "podman pull by digest and list --all" test: untag instead of rmi f417861e0 build(deps): bump golang.org/x/text from 0.8.0 to 0.9.0 43e6bc9d9 Add renovate.json configuration cf6f13704 CI: postbuild step: skip under nightly treadmill db9785ba5 The `--ulimit` option accepts the name with an `RLIMIT_` prefix both upper and lower case dc9a65e34 test/e2e: use custom network config dir where needed 35165df37 chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` b858c7e7f update completion scripts for cobra v1.7.0 e4aad8f0f libpod.storageService.CreateContainerStorage(): retrieve ID maps d0ffb8792 Fix invalid pod name and hostname during kube generate 761eca9e7 e2e tests: fix racy flakes 56e7b511e Cirrus: Enable labeling of EC2 VMs 74f9fd8e6 Cirrus: Fix aarch64 clone_script 404 errors ce8a3a0c1 e2e: GinkgoParallelNode() -> ...Process() 45b1099ef build(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0 34a5c7f15 build(deps): bump golang.org/x/sys from 0.6.0 to 0.7.0 10d2e9fde [CI:DOCS] --creds and registries 9b7fd3936 Copr: fix build deps for /usr/bin/envsubst 80f9f8077 Don't error when removing non-existant env vars ecce01e61 e2e: healthcheck on stopped container: fix flake cb7b8fb31 test/apiv2/80-kube.at e1be7d141 test/apiv2/80-kube.at 1f3ae8a4f system service: do not close Body bb70d60f1 rm `hack/release.sh` 704901d11 build(deps): bump github.com/onsi/gomega from 1.27.5 to 1.27.6 243ca7c28 add `quadlet -version` flag 7eb78f8a7 add version/rawversion package 53b16ccd2 quadlet: use `Flag` suffix for variables 443f8d89c quadlet: implement `Tmpfs` option 91ca15e96 Bump to v4.5.0-dev 3e48017d8 Bump to 4.5.0-rc1 b7175a366 Update release notes from 4.4 branch 2051e54e0 rootless netns: recover from invalid netns 99ace1908 System tests: unverbosify a flake log 68dbddd97 Add support for secret exists 78e7ade0d Fix Win install task failures with large PR bodies 21febcb5c docs: add `starting` to `HealthCheckResults.Status` d7051d745 Add support for cgroup_config from containers.conf 4d56292e7 libpod: mount safely subpaths 4f9019406 Support Deployment generation with kube generate 8b6a7c182 Use secret.items to create volume mounts if present 359f40869 [CI:DOCS] fix typo in --systemd option 266cc7882 rootless: drop preexec hook error message 3c9ce3e52 Edit the docker wrapper to use the install prefix 5643058c8 Update podman-for-windows.md d79519e70 Quadlet: RemapUsers documentation fixes 7f8d5e565 speed up image listing f0cfbbe2c vendor containers/common@e27c30ee9b1b 70abb4ae5 fix volume-plugin-test flake b3e8791f6 Document building Podman remote on Windows hosts c40eaa242 test/e2e: gpg keep stdout/err attached f131eaa74 auto-update: stop+start instead of restart sytemd units b7a8e1285 [CI:DOCS] Improve basic tutorial be7827c7e Update docs/source/markdown/podman-network.1.md c335ff241 Add debug to --wait test 81e5bffc3 fix slirp4netns resolv.conf ip with a userns 11e5c2d0f Quadlet: add support for keep-id with mapping values b5df38c23 Quadlet E2E test - run quadlet as user generator cdb5b3e99 sqlite: do not `Ping()` after connecting da96ff6cc Quadlet - treat paths starting with systemd specifiers as absolute dd8ee49f6 Update docs/source/markdown/podman-kube-play.1.md.in d85c8d7e8 system tests: use CONTAINERS_CONF_OVERRIDE 51d068ecc implement podman machine set for hyperv 46b826a90 [CI:DOCS] Add network subnets info to network man page dd8574022 CI: retry the golangci install 92e0efc5d system tests: fix racey sdnotify test 518eafaa3 hyperv: lookup machine on local filesystem first 4c72fc26b fix os.IsNotExist() CI check 7daab31f1 Ensure that SQLite state handles name-ID collisions 64ba82601 macos pkginstaller: do not fail when podman-mac-helper fails 4f3cbf15c podman-mac-helper: install: do not error if already installed ade46ae6a build(deps): bump github.com/onsi/gomega from 1.27.4 to 1.27.5 e061cb968 Fix a race around SQLite DB config validation c5fc44582 add CONTAINERS_CONF_OVERRIDE 5f86fae71 vendor containers/common@main 6825740fc docs: minor grammar fix in `--volume` description b31d9e15f sqlite: do not use shared cache 9be4a525f test: podman checkpoint/restore the latest container 5185e7e39 stats compat API: return "id" lowercase 5f274e45f Run make codespell 3925cd653 Drop SQLite max connections 0fbc32515 sqlite: set connection attributes on open 9f0e0e833 Fix database locked errors with SQLite cf5df5b80 quadlet tests: skip on RHEL8 rootless cb24d6c3d Kube Play Doc: Document the support for K8S Secret 6b2101bc7 New ulimit test: bump up minimum nfiles 5447e88b4 logformatter: hide --db-backend, and friendlyize quadlet 5382997e0 Quadlet - add support for relative path in Volume key in .container file 3e405a2fd Add service ctr cleanup to PlayKubeDown 956341543 fix --health-on-failure=restart in transient unit 26d5df77d Quadlet Doc: Suggest the kill operation for HealthOnFailure 5d1342fc5 Quadlet - Add support for health checks configuration in .container files 3ef707def Makefile: allow specifying /lib dir location a5abbdf1f Fix option --opts -> --opt 0dac214f5 basic hypverv machine implementation 94f905a50 Fix SQLite DB schema migration code 46d165040 Add support for oom_score_adj value from containers.conf 6046832f3 Use default_ulimits field in containers.conf e2d49fb65 CI: test and confirm DESIRED_DATABASE 1ea62f32f build(deps): bump github.com/openshift/imagebuilder 526dfb893 logformatter: futureproof output filename e21cf2d8d Vendor in latest containers/(storage, common, image) 686bdcc29 build(deps): bump google.golang.org/protobuf from 1.29.0 to 1.30.0 ba141adce test/system/255-auto-update.bats: add debug logs c2a24abc0 Revert "Revert "pasta: Use two connections instead of three in TCP range forward tests"" 3a59af219 Add information for secret inspect 87e93a7b6 Add format to podman volume ls b424f8fb0 Add format to podman volume inspect 2555c8034 Add format to podman secret ls 1c4bd4a73 Add format to podman system df 71bcd9891 Add format to podman machine info 581611844 Add format table to podman image inspect man page e92955245 Cirrus: Store podman machine benchmark data b3035b9d6 Update Cirrus display names, and fix get-ci-vm script 6142c16a9 Ensure SQLite places uses the runroot in transient mode 2ec11b16a Fix various integration test issues with SQLite state 0f8530b1e Remove test for pod/container name global uniqueness 6e0f11da5 Improve handling of existing container names in SQLite 39fd9aa08 Add SQLite job to CI 7ed1c7fd9 buildah treadmill: also run rootless tests 2b4a27719 build(deps): bump github.com/vbatts/git-validation in /test/tools 3c51b61d7 auto update: return restart error ea2a0767a fix: Document removing anonymous volumes 408e764b9 events: no duplicates when streaming during a log rotation 82f2f8258 Add search --cert-dir, --creds bae07b6ea podman-mac-helper: exit 1 on error 7d8d3e810 system service --log-level=trace: support hijack eed389508 test/system: fix wait_for_port() to wait for bind 2d1f4a8bf cgroupns: private cgroupns on cgroupv1 breaks --systemd 01fd5bcc3 libpod: remove error stutter 4562e61d2 podman events: unhide --stream 7a7af735a test/system/255-auto-update.bats: multiple services 40d0d233e 255-auto-update.bats: turn off rollback where needed a9d70e9fe Use append() to add elements to a slice 1c08f2eda Revert "pasta: Use two connections instead of three in TCP range forward tests" ad8a96ab9 Support running nested SELinux container separation 159936a11 bud tests: rootless remote: use correct socket path 6f9f395b3 build(deps): bump github.com/vbauerster/mpb/v8 from 8.2.1 to 8.3.0 bad41f67e compat: /auth: parse server address correctly 6363fb08f docs: fix cmd `set DOCKER_HOST` suggestion fb4f6f95c test: reenable idmap test b5a99e081 Must use mountlabel when creating builtin volumes 8d952c01d podman.spec.rpkg: distro conditionals for modulesloaddir 9294b7350 build(deps): bump google.golang.org/protobuf from 1.28.1 to 1.29.0 21651706e podman inspect list network when using --net=host or none f928cf54a pasta: Re-enable "Local forwarder, IPv4" test, accept NXDOMAIN as response 829e910cd build(deps): bump golang.org/x/tools from 0.6.0 to 0.7.0 in /test/tools cc7a1e614 CI: Switch to c20230307t192532z-f37f36d12 images 799c20177 Cirrus: Run system & integration tests in parallel c03cb5718 Update checkpointctl v0.1.0 cb3cda55f Quadlet: add support for setting --ip and --ip6 af7a759e9 build(deps): bump golang.org/x/net from 0.7.0 to 0.8.0 5d039ce22 build(deps): bump golang.org/x/sys from 0.5.0 to 0.6.0 34ff27b81 libpod: avoid nil pointer dereference in (*Container).Cleanup 25dd4d653 [CI:DOCS] Add image not found info to troubleshooting 0498ce3a5 cmd: do not require userns for "version" 2860d55c9 cmd: drop special handling for "scp" da04469f0 cmd: clarify meaning of ParentNSRequired 0ab4b2614 Fix package restore 0d219486f [CI:DOCS] Fix docs/version-check always requesting updates e77f370f8 sqlite: add a hidden --db-backend flag cca65db01 fix: update the default machine value when the previously set default machine is deleted 9ac0d4f1a podman machine: Adjust Chrony makestep config 2c67ff5d4 sqlite: add container short ID to network aliases 38acab832 sqlite: remove dead code 2342d1a31 sqlite: addContainer: add named volume only once 86d12520e sqlite: implement RewriteVolumeConfig df88f546b sqlite: LookupVolume: fix partial name match 01359457c sqlite: LookupVolume: wrap error 69ff04f73 sqlite: fix type rewriting container config e87014e44 sqlite: return correct error on pod-name conflict 84b5c6c71 sqlite: RewritePodConfig: update error message 51cf2dd36 test/system/255-auto-update.bats: wait 10 for update to finish b727f30ac auto-update test: wait for service to be ready 76056c670 Vendor in latest containers/(common, storage, image) 20a42d0e4 play kube: Add --wait option 6babef598 Cirrus: Fix git config permission denied ccc5aa59a Quadlet: Add support for the Mount key in .container files 6f09dbc2d build(deps): bump github.com/onsi/gomega from 1.27.1 to 1.27.2 77861d6af fix "podman logs --since --follow" flake 6d352dc0b Clarify that replicas are ignored in kubernetes deployment 42540a667 Revert "Skip all pasta tests" e804ddc5a CI: Switch to c20230223t153813z-f37f36d12 images 070572245 Fix user socket path 1e516e657 pkginstaller: bump Qemu to version 7.2.0 0f92e19e8 Cirrus: Fix bud tests failing to apply patches 1ef8a860c build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2 b00874c16 build(deps): bump github.com/coreos/stream-metadata-go 9d93486d2 Vendor in latest containers/storage d838c08b3 buildah-bud tests: don't sudo when rootless is desired 1f6f81f5d Temporarily disable version-check 5a08ddaec CI: new rootless buildah-bud tests (cron only) 5d2d609be sqlite: fix volume lookups with partial names 495314a16 sqlite: fix container lookups with partial IDs efe7aeb1d sqlite: fix LookupPod 19c2f37ba sqlite: fix pod create/rm e32bea937 sqlite: LookupContainer: update error message 565bb5645 sqlite: AddContainerExitCode: allow to replace 4b3b94473 system: add warning when running rootless on cgroupv1 1b1cdfa35 sqlite: fix AllContainers with state 21fcc9070 sqlite: fix "UPDATE TABLE" typos 3f96b0ef2 sqlite: SaveVolume: fix syntax error updating the volumes table 7c11f7e17 sqlite: exit code: allow -1 e74f7bcaf sqlite: fix typo when removing exec sessions 560805ac4 sqlite: AllContainers: fix inner join 8c64c4370 sqlite: move migration after table creation eeabe975e sqlite: implement pod methods 0d75854c5 Quadlet - use the default runtime 49d560e1b docs: context is not optional for build 03aaa8d35 Fix an incorrect comment on NewSqliteState eb228f264 Add support for containers.conf database setting 59a54f32d Add support for volume operations to SQLite state c0b92bdbc Implement exec session handling in SQL database 627a5b73b Various fixes from code review c4fe0af2a Remove `--namespace` flag from Podman root 89d0ccd19 Get E2E tests to pass 97499a70a Implement network disconnect for SQLite state 939a4ccef Implement Network Connect/Modify for SQLite state 8ab18d848 Fix various lint issues b4c4f9c93 Some further work on SQLite state 5c2a0670f Remove concept of Namespaces from BoltDB 1b968c607 Add initial SQLite-backed state implementation 93e7cc119 Cirrus: Support runc testing on debian VMs 81f116c59 Skip all pasta tests 642e9ddb8 Skip buildah-bud test 10382d0bc Skip buildx test with VFS podman storage driver dd51b62b7 Skip 'podman kube --network' test for rootless CGv1 197529f08 Skip tests which fail with CGv1 & runc 5b4f248a8 Skip rootless CGv1 quadlet tests due to issue e19922d09 Makefile: Define SHELL 43eb35a77 Machine refactor for QEMU/AppleHV e838ad86b machine refactoring preparations for hyperv b4471c6ed [CI:BUILD] spec.rpkg: trim dependency list 12153da83 Logs follow-until tests: loosen checks 7d17ec07f [CI:DOCS] Windows/Mac docs link update 7f5fc04b4 Doc update for docker network options via CLI 4b4b423b6 compat API: network create return 409 for duplicate 40f21da0c Apply suggestions to man page adacd3b12 vendor c/common@852ca05a1fbb 6a3757b73 Quadlet: Add support for LogDriver key in container and kube units ebb45b5bd machine refactoring preparations for hyperv af8d649da libpod: always use direct mapping 9dc730d9f netavark: only use aardvark ip as nameserver e9942c61d build(deps): bump github.com/container-orchestrated-devices/container-device-interface 79a05ca2b podman logs passthrough driver support --cgroups=split d7e96536e journald logs: simplify entry parsing 1590c7bf4 podman logs: read journald with passthrough 5754df806 make docs: sanity check for broken man pages 5056bd45f build(deps): bump github.com/vbauerster/mpb/v8 from 8.1.6 to 8.2.0 5fcd2c3fa build(deps): bump github.com/onsi/gomega from 1.27.0 to 1.27.1 2659a3228 kube: rm secret on down, print secret on play 9ce589a4a Fix spacing typo that triggered OCD & indent units in podman-systemd.unit(5) ad866fecb Update remote_client.md e74f60dee [CI:DOCS] Add restriction to option README 975b096bc Revert "CI: Temporarily disable all AWS EC2-based tasks" 22a207d45 build(deps): bump github.com/onsi/gomega from 1.26.0 to 1.27.0 c95978f60 kube play: only enforce passthrough in Quadlet 21cddd723 journald: remove initializeJournal() 6dd797844 auto-update: support pods 9622d25be Emergency fix for man pages: check for broken includes c81fbd5d0 System tests: assert(): friendlier failure messages 761da776a Cirrus: Fix version-check to only run on `main` job 7f8bc6f51 CI: Temporarily disable all AWS EC2-based tasks 6f5ca7318 build(deps): bump github.com/containerd/containerd from 1.6.16 to 1.6.18 6ca857feb volume,container: chroot to source before exporting content 94d4b5278 Support sysctl configs via podman kube play 510e44359 [CI:BUILD] copr: podman.spec.rpkg cleanups a4677405c quadlet system tests: add useful defaults, logging 96af9e4e0 libpod: support relative positions for idmaps c7ee65596 Experimental workaround for cdn03.quay.io flake 86e55d0ec system tests: prevent leading tabs 9abe8c785 Introduce podman machine os apply 828708bac create: add support for --group-entry 33a918711 fix != filter in volume prune 4c5b79120 Allow specification of podman --remote build -f - 3d8936642 Quadlet use crun specified in containers.conf 9f84b9b52 build(deps): bump golang.org/x/net from 0.6.0 to 0.7.0 86a4c6b65 Vendor c/image after containers/image#1847 c0f983db8 Don't set hostPort when generating a service 3a9d14d4e man page --format xref: tighten the autocompletion check 0999991b2 add support for limiting tmpfs size for systemd-specific mnts 9a1f47887 build(deps): bump golang.org/x/text from 0.6.0 to 0.7.0 35d16ea02 Add ulimit annotation to kube gen & play 34d412e13 man page xref: validate displayed man page names 7c54d1423 quadlet: add ExecStop d2ac85f7a install sigproxy before start/attach 191e4ce40 build(deps): bump golang.org/x/tools from 0.5.0 to 0.6.0 in /test/tools a5ca73225 Fix typos 45fb353f4 Cirrus: Make benchmarks .env file easier to load a7db3e8d2 Cirrus: Omit functions in env. file 1541ce56c kube play: set service container as main PID when possible 08e13867a Fix typos. Improve language. 9cba0474b events + container inspect test: RHEL fixes 5a9074dab Add ctrName to network alias during kube play 586515976 Run codespell on codebase c7619c8ae podman image scp: added identity for ssh.Exec fb54be2e1 [CI:DOCS] Clarify nomap constrains 433413549 [CI:DOCS] man-page checker: include --format (Go templates) e308ba021 Vendor c/image after containers/image#1816 ec4ab08c8 [CI:DOCS] Cleanup some man pages to display options with line breaks 5ed217409 [CI:DOCS] Add tables to podman-systemd.unit man page 3de409ad6 github: remove prefix from bugs/features d6dd17fdf Quadlet: Add support for the Secret key in Container group 08d28bfc2 [CI:DOCS] OWNERS: add @ygalblum and @alexlarsson 47df0ca25 build(deps): bump golang.org/x/term from 0.4.0 to 0.5.0 ded44be16 build(deps): bump github.com/vbauerster/mpb/v8 from 8.1.4 to 8.1.6 42c7c59dd Sort quadlet keys to make it easier to read 43b357068 e2e: fix some tests on remote 83367a6b3 kube play: do not teardown unconditionally on error ac71fa01c Fix typos in comments 6b6458916 Resolve symlink path for qemu directory if possible 90eb834e7 #17363 Fix contradicting documentation podman-commit 1916da596 Fix a potential UID/GID collision in unit tests 93c35a703 golangci-lint: show all errors at once 77e4b1939 update golangci-lint to version 1.51.1 1fd0ce71d [CI:DOCS] events: document journald identifiers f1352521f Quadlet: exit 0 when there are no files to process ced934284 network ls: handle removed container 315215020 e2e: adapt play kube test on remote rootless 4e8906c5e docs/podman-systemd.unit: Explicitely mention network & kube units c4f338eec docs/podman-systemd.unit: Update example to work out of the box 50f72fe7b [CI:BUILD] Cirrus: Fix GraphQL ownerRepository:null error 83a0e97ab Add missing return after errors 84c674fee Revert "Cirrus: Emergency fix to un-stuck PRs" af0f10a22 pasta: Fix ICMPv6 Echo test, skip it for the moment 859579b6b pasta: Fix ICMP Echo Request (IPv4) test e33f4e0bc pasta: Use two connections instead of three in TCP range forward tests acaab3fa7 Add SELinux label types support to quadlet 928d589b7 Add quadlet support for rootfs= containers 6b3073f53 Cirrus: Emergency fix to un-stuck PRs 8441f01be Move clean-binaries before podman-remote in podman-remote-docs target aa0d4b266 oci: bind mount /sys with --userns=(auto|pod:) e6904f6f8 Cleanup podman-systemd.unit file 3c3526e53 Install podman-systemd.unit man page, make quadlet discoverable de63ad704 libpod: allow userns=keep-id for root 9e7f1bea4 system-reset: use CleanCacheMount to clear build cache 5ca35d6de vendor: bump buildah to v1.29.1-0.20230201192322-e56eb25575c7 3ce07b556 system tests: fix noexistent labels test in the remote a909e2f2d Expose Podman named pipe in Inspect output 2bb4c7cdd libpod: support idmap for --rootfs ed1f76917 test: adapt test to work on cgroupv1 ed18cdd6e Bump to v4.5.0-dev b6d91ebfb Update main to reflect v4.4.0 release be47eeb85 Update from /github.com/vbauerster/mpb/v7 to /v8 8aa377698 hack/perf: cleanup after benchmarks cb5a9e9f4 hack/perf/bz-2162111.sh: use custom network a1436d8fb Update bug_report.yaml 02bcf0bac Handle filetype field in kubernetes.yaml files 1a786ea53 hack/perf/bz-2162111.sh: measure stop bd8937c50 make hack/markdown-preprocess parallel-safe 68371ff55 system tests: fix volume exec/noexec test f69efb6ee system tests: minor fix for RHEL8 incompatibility cf7afed05 Cirrus: Use versionable IMAGE_SUFFIX cbb45a6d4 utils: new conversion method 0e949bfd3 libpod: use GraphRoot for overlay upper dir 427d69cc3 vendor: update containers/storage d10860a32 Do not mount /dev/tty into rootless containers 5c059e3ed build(deps): bump go.etcd.io/bbolt from 1.3.6 to 1.3.7 9272cabd3 e2e: fix run_staticip_test about no_proxy 2e397120d docs: specify order preference for FROM 15594e92e Fixes port collision issue on use of --publish-all 952049fe5 Support for Windows paths in the source position of the volume mounts 0e3524b8b e2e tests: fix incorrect os.User.Name 7c60a784c Log data that we failed to unmarshal 61db1d5aa [CI:DOCS] hack/perf: add script for BZ 216111 29b346dea container rm: save once for exec removal and state change 8f2a40d81 [DOCS:CI] podman-events: document verbose create events 7e80edd3a e2e: Avoid hard-coding included in quadlet test 2682d3ad9 e2e: Avoid hard-coding ImageCacheDir 387f0ea2f Making gvproxy.exe optional for building Windows installer 74c090973 Add gvproxy to Windows packages ab8e49d74 Add comment to clarify error handling intention 12d70446f fix #17244: use /etc/timezone where `timedatectl` is missing on Linux 063e273e9 Fix usage of absolute windows paths with --image-path b0b166b5b Match VT device paths to be blocked from mounting exactly 553e53d44 Fix default handling of pids-limit 069edc3ad Add (podman {image,manifest} push --sign-by-sigstore=param-file.yaml) e51991030 journald: podman logs only show logs for current user 2ab90f2ed journald: podman events only show events for current user 21b82bb68 e2e: Remove the cache with "podman unshare rm" when a rootless user 9db657f40 Clean up more language for inclusiveness 814f7c569 e2e: Remove some directories at SynchronizedAfterSuite 497be102a fix: don't output "ago" when container is currently up and running b28519fd9 fix: running check error when podman is default in wsl a745d99a8 fix CI: test fail due to merge f3d8f6c49 Bump Bulidah to v1.29.0 38d5319f1 e2e: reduce dependency on /tmp for e2e tests 0ffce8181 Bump cirrus image with easier dependency management e62e42bfa quadlet: Add device support for .volume files 70e8f6243 remote,build: error if containerignore is symlink c74bdae35 DB: make loading container states optional 6132c4d54 ps: do not sync container 958c94094 Set runAsNonRoot=true in gen kube 7aef3301d WSL refactoring 08186d7dd kube-play: add support for HostIPC in pod.Spec 8850db961 Allow --device-cgroup-rule to be passed in by docker API Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>

@ygalblum

This version introduces envsubt in the install stage, so we add gettext-native to our build dependencies. Bumping libpod to version v4.5.0-14-gc926b12c5, which comprises the following commits: bc2f0115d [v4.5] system tests: fix race in kube-play read-only 696c2d40d api: fix parsing filters 1fa2eb53b Support systemd optional prefix '-' for devices. 74634a46c *: migrate image registry to registry.k8s.io 0fb11cccd Makefile: include `release-artifacts` target 4d2cf293e [CI:BUILD] Packit: Initial Enablement da927a75c Bump to v4.5.1-dev 75e3c1257 Release v4.5.0 32a6892b6 [CI:DOCS] Final release notes for v4.5.0 5de2a13e0 Quadlet - do not set log-driver by default c5e704c82 Return title fields as a list bf6f58b02 Bump to v4.5.0-dev f3c365887 Bump to v4.5.0-RC2 15c302533 Final release notes for v4.5.0-RC2 af7c25811 test/e2e: remove unnecessary SkipIfNetavark() calls 80652cacf test/e2e: deduplicated network test b526839a4 docs: update podman-network-create.1 ed99a979c network create: add --interface-name 676486a85 test/system/252-quadlet.bats: fix flake 1bf5bdc68 Read kube_generate_type from containers.conf 11ac0d03e Debian setup: workaround for runc /dev/char/10:200 bug 38c217a0b pkg/rootless: use catatonit from /usr/libexec/podman bab95de9a rootless: make sure we only use a single pause process 3b2b1441e Use atomic config writing strategy for podman machine config files 67307603b Add remaining release notes for v4.5.0-RC2 d53871cf1 GHA: Use version instead of SHA for actions 25bc7d161 chore(deps): update dependency containers/automation_images to v20230405 944accffa build: pass env by reference 7edf73dfd test: retrofit error message b624ad757 test/system: expect 12 char for short id 260bc3ec4 vendor: bump containers/(storage, common, buildah, image) c5a0d8646 [skip-ci] Update actions/upload-artifact action to v3 d3cf8ccf8 [skip-ci] Update actions/stale action to v8 21fbd5c1a [skip-ci] Update actions/setup-go action to v4 f3971e412 [skip-ci] Update github/issue-labeler action to v2.6 c4e79fc16 Fix up codespell errors a5dd5c20e Capitalize all uid,gid and id words that are not options in docs 352a41e3a build(deps): bump golang.org/x/tools from 0.7.0 to 0.8.0 in /test/tools 13135f924 Properly remove the service container during kube down f6a50311c quadlet: add `UserNS` option key 29aac4dfe [CI:DOCS] Release notes for 4.5.0 Part 1 358b46225 "podman pull by digest and list --all" test: untag instead of rmi f417861e0 build(deps): bump golang.org/x/text from 0.8.0 to 0.9.0 43e6bc9d9 Add renovate.json configuration cf6f13704 CI: postbuild step: skip under nightly treadmill db9785ba5 The `--ulimit` option accepts the name with an `RLIMIT_` prefix both upper and lower case dc9a65e34 test/e2e: use custom network config dir where needed 35165df37 chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` b858c7e7f update completion scripts for cobra v1.7.0 e4aad8f0f libpod.storageService.CreateContainerStorage(): retrieve ID maps d0ffb8792 Fix invalid pod name and hostname during kube generate 761eca9e7 e2e tests: fix racy flakes 56e7b511e Cirrus: Enable labeling of EC2 VMs 74f9fd8e6 Cirrus: Fix aarch64 clone_script 404 errors ce8a3a0c1 e2e: GinkgoParallelNode() -> ...Process() 45b1099ef build(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0 34a5c7f15 build(deps): bump golang.org/x/sys from 0.6.0 to 0.7.0 10d2e9fde [CI:DOCS] --creds and registries 9b7fd3936 Copr: fix build deps for /usr/bin/envsubst 80f9f8077 Don't error when removing non-existant env vars ecce01e61 e2e: healthcheck on stopped container: fix flake cb7b8fb31 test/apiv2/80-kube.at e1be7d141 test/apiv2/80-kube.at 1f3ae8a4f system service: do not close Body bb70d60f1 rm `hack/release.sh` 704901d11 build(deps): bump github.com/onsi/gomega from 1.27.5 to 1.27.6 243ca7c28 add `quadlet -version` flag 7eb78f8a7 add version/rawversion package 53b16ccd2 quadlet: use `Flag` suffix for variables 443f8d89c quadlet: implement `Tmpfs` option 91ca15e96 Bump to v4.5.0-dev 3e48017d8 Bump to 4.5.0-rc1 b7175a366 Update release notes from 4.4 branch 2051e54e0 rootless netns: recover from invalid netns 99ace1908 System tests: unverbosify a flake log 68dbddd97 Add support for secret exists 78e7ade0d Fix Win install task failures with large PR bodies 21febcb5c docs: add `starting` to `HealthCheckResults.Status` d7051d745 Add support for cgroup_config from containers.conf 4d56292e7 libpod: mount safely subpaths 4f9019406 Support Deployment generation with kube generate 8b6a7c182 Use secret.items to create volume mounts if present 359f40869 [CI:DOCS] fix typo in --systemd option 266cc7882 rootless: drop preexec hook error message 3c9ce3e52 Edit the docker wrapper to use the install prefix 5643058c8 Update podman-for-windows.md d79519e70 Quadlet: RemapUsers documentation fixes 7f8d5e565 speed up image listing f0cfbbe2c vendor containers/common@e27c30ee9b1b 70abb4ae5 fix volume-plugin-test flake b3e8791f6 Document building Podman remote on Windows hosts c40eaa242 test/e2e: gpg keep stdout/err attached f131eaa74 auto-update: stop+start instead of restart sytemd units b7a8e1285 [CI:DOCS] Improve basic tutorial be7827c7e Update docs/source/markdown/podman-network.1.md c335ff241 Add debug to --wait test 81e5bffc3 fix slirp4netns resolv.conf ip with a userns 11e5c2d0f Quadlet: add support for keep-id with mapping values b5df38c23 Quadlet E2E test - run quadlet as user generator cdb5b3e99 sqlite: do not `Ping()` after connecting da96ff6cc Quadlet - treat paths starting with systemd specifiers as absolute dd8ee49f6 Update docs/source/markdown/podman-kube-play.1.md.in d85c8d7e8 system tests: use CONTAINERS_CONF_OVERRIDE 51d068ecc implement podman machine set for hyperv 46b826a90 [CI:DOCS] Add network subnets info to network man page dd8574022 CI: retry the golangci install 92e0efc5d system tests: fix racey sdnotify test 518eafaa3 hyperv: lookup machine on local filesystem first 4c72fc26b fix os.IsNotExist() CI check 7daab31f1 Ensure that SQLite state handles name-ID collisions 64ba82601 macos pkginstaller: do not fail when podman-mac-helper fails 4f3cbf15c podman-mac-helper: install: do not error if already installed ade46ae6a build(deps): bump github.com/onsi/gomega from 1.27.4 to 1.27.5 e061cb968 Fix a race around SQLite DB config validation c5fc44582 add CONTAINERS_CONF_OVERRIDE 5f86fae71 vendor containers/common@main 6825740fc docs: minor grammar fix in `--volume` description b31d9e15f sqlite: do not use shared cache 9be4a525f test: podman checkpoint/restore the latest container 5185e7e39 stats compat API: return "id" lowercase 5f274e45f Run make codespell 3925cd653 Drop SQLite max connections 0fbc32515 sqlite: set connection attributes on open 9f0e0e833 Fix database locked errors with SQLite cf5df5b80 quadlet tests: skip on RHEL8 rootless cb24d6c3d Kube Play Doc: Document the support for K8S Secret 6b2101bc7 New ulimit test: bump up minimum nfiles 5447e88b4 logformatter: hide --db-backend, and friendlyize quadlet 5382997e0 Quadlet - add support for relative path in Volume key in .container file 3e405a2fd Add service ctr cleanup to PlayKubeDown 956341543 fix --health-on-failure=restart in transient unit 26d5df77d Quadlet Doc: Suggest the kill operation for HealthOnFailure 5d1342fc5 Quadlet - Add support for health checks configuration in .container files 3ef707def Makefile: allow specifying /lib dir location a5abbdf1f Fix option --opts -> --opt 0dac214f5 basic hypverv machine implementation 94f905a50 Fix SQLite DB schema migration code 46d165040 Add support for oom_score_adj value from containers.conf 6046832f3 Use default_ulimits field in containers.conf e2d49fb65 CI: test and confirm DESIRED_DATABASE 1ea62f32f build(deps): bump github.com/openshift/imagebuilder 526dfb893 logformatter: futureproof output filename e21cf2d8d Vendor in latest containers/(storage, common, image) 686bdcc29 build(deps): bump google.golang.org/protobuf from 1.29.0 to 1.30.0 ba141adce test/system/255-auto-update.bats: add debug logs c2a24abc0 Revert "Revert "pasta: Use two connections instead of three in TCP range forward tests"" 3a59af219 Add information for secret inspect 87e93a7b6 Add format to podman volume ls b424f8fb0 Add format to podman volume inspect 2555c8034 Add format to podman secret ls 1c4bd4a73 Add format to podman system df 71bcd9891 Add format to podman machine info 581611844 Add format table to podman image inspect man page e92955245 Cirrus: Store podman machine benchmark data b3035b9d6 Update Cirrus display names, and fix get-ci-vm script 6142c16a9 Ensure SQLite places uses the runroot in transient mode 2ec11b16a Fix various integration test issues with SQLite state 0f8530b1e Remove test for pod/container name global uniqueness 6e0f11da5 Improve handling of existing container names in SQLite 39fd9aa08 Add SQLite job to CI 7ed1c7fd9 buildah treadmill: also run rootless tests 2b4a27719 build(deps): bump github.com/vbatts/git-validation in /test/tools 3c51b61d7 auto update: return restart error ea2a0767a fix: Document removing anonymous volumes 408e764b9 events: no duplicates when streaming during a log rotation 82f2f8258 Add search --cert-dir, --creds bae07b6ea podman-mac-helper: exit 1 on error 7d8d3e810 system service --log-level=trace: support hijack eed389508 test/system: fix wait_for_port() to wait for bind 2d1f4a8bf cgroupns: private cgroupns on cgroupv1 breaks --systemd 01fd5bcc3 libpod: remove error stutter 4562e61d2 podman events: unhide --stream 7a7af735a test/system/255-auto-update.bats: multiple services 40d0d233e 255-auto-update.bats: turn off rollback where needed a9d70e9fe Use append() to add elements to a slice 1c08f2eda Revert "pasta: Use two connections instead of three in TCP range forward tests" ad8a96ab9 Support running nested SELinux container separation 159936a11 bud tests: rootless remote: use correct socket path 6f9f395b3 build(deps): bump github.com/vbauerster/mpb/v8 from 8.2.1 to 8.3.0 bad41f67e compat: /auth: parse server address correctly 6363fb08f docs: fix cmd `set DOCKER_HOST` suggestion fb4f6f95c test: reenable idmap test b5a99e081 Must use mountlabel when creating builtin volumes 8d952c01d podman.spec.rpkg: distro conditionals for modulesloaddir 9294b7350 build(deps): bump google.golang.org/protobuf from 1.28.1 to 1.29.0 21651706e podman inspect list network when using --net=host or none f928cf54a pasta: Re-enable "Local forwarder, IPv4" test, accept NXDOMAIN as response 829e910cd build(deps): bump golang.org/x/tools from 0.6.0 to 0.7.0 in /test/tools cc7a1e614 CI: Switch to c20230307t192532z-f37f36d12 images 799c20177 Cirrus: Run system & integration tests in parallel c03cb5718 Update checkpointctl v0.1.0 cb3cda55f Quadlet: add support for setting --ip and --ip6 af7a759e9 build(deps): bump golang.org/x/net from 0.7.0 to 0.8.0 5d039ce22 build(deps): bump golang.org/x/sys from 0.5.0 to 0.6.0 34ff27b81 libpod: avoid nil pointer dereference in (*Container).Cleanup 25dd4d653 [CI:DOCS] Add image not found info to troubleshooting 0498ce3a5 cmd: do not require userns for "version" 2860d55c9 cmd: drop special handling for "scp" da04469f0 cmd: clarify meaning of ParentNSRequired 0ab4b2614 Fix package restore 0d219486f [CI:DOCS] Fix docs/version-check always requesting updates e77f370f8 sqlite: add a hidden --db-backend flag cca65db01 fix: update the default machine value when the previously set default machine is deleted 9ac0d4f1a podman machine: Adjust Chrony makestep config 2c67ff5d4 sqlite: add container short ID to network aliases 38acab832 sqlite: remove dead code 2342d1a31 sqlite: addContainer: add named volume only once 86d12520e sqlite: implement RewriteVolumeConfig df88f546b sqlite: LookupVolume: fix partial name match 01359457c sqlite: LookupVolume: wrap error 69ff04f73 sqlite: fix type rewriting container config e87014e44 sqlite: return correct error on pod-name conflict 84b5c6c71 sqlite: RewritePodConfig: update error message 51cf2dd36 test/system/255-auto-update.bats: wait 10 for update to finish b727f30ac auto-update test: wait for service to be ready 76056c670 Vendor in latest containers/(common, storage, image) 20a42d0e4 play kube: Add --wait option 6babef598 Cirrus: Fix git config permission denied ccc5aa59a Quadlet: Add support for the Mount key in .container files 6f09dbc2d build(deps): bump github.com/onsi/gomega from 1.27.1 to 1.27.2 77861d6af fix "podman logs --since --follow" flake 6d352dc0b Clarify that replicas are ignored in kubernetes deployment 42540a667 Revert "Skip all pasta tests" e804ddc5a CI: Switch to c20230223t153813z-f37f36d12 images 070572245 Fix user socket path 1e516e657 pkginstaller: bump Qemu to version 7.2.0 0f92e19e8 Cirrus: Fix bud tests failing to apply patches 1ef8a860c build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2 b00874c16 build(deps): bump github.com/coreos/stream-metadata-go 9d93486d2 Vendor in latest containers/storage d838c08b3 buildah-bud tests: don't sudo when rootless is desired 1f6f81f5d Temporarily disable version-check 5a08ddaec CI: new rootless buildah-bud tests (cron only) 5d2d609be sqlite: fix volume lookups with partial names 495314a16 sqlite: fix container lookups with partial IDs efe7aeb1d sqlite: fix LookupPod 19c2f37ba sqlite: fix pod create/rm e32bea937 sqlite: LookupContainer: update error message 565bb5645 sqlite: AddContainerExitCode: allow to replace 4b3b94473 system: add warning when running rootless on cgroupv1 1b1cdfa35 sqlite: fix AllContainers with state 21fcc9070 sqlite: fix "UPDATE TABLE" typos 3f96b0ef2 sqlite: SaveVolume: fix syntax error updating the volumes table 7c11f7e17 sqlite: exit code: allow -1 e74f7bcaf sqlite: fix typo when removing exec sessions 560805ac4 sqlite: AllContainers: fix inner join 8c64c4370 sqlite: move migration after table creation eeabe975e sqlite: implement pod methods 0d75854c5 Quadlet - use the default runtime 49d560e1b docs: context is not optional for build 03aaa8d35 Fix an incorrect comment on NewSqliteState eb228f264 Add support for containers.conf database setting 59a54f32d Add support for volume operations to SQLite state c0b92bdbc Implement exec session handling in SQL database 627a5b73b Various fixes from code review c4fe0af2a Remove `--namespace` flag from Podman root 89d0ccd19 Get E2E tests to pass 97499a70a Implement network disconnect for SQLite state 939a4ccef Implement Network Connect/Modify for SQLite state 8ab18d848 Fix various lint issues b4c4f9c93 Some further work on SQLite state 5c2a0670f Remove concept of Namespaces from BoltDB 1b968c607 Add initial SQLite-backed state implementation 93e7cc119 Cirrus: Support runc testing on debian VMs 81f116c59 Skip all pasta tests 642e9ddb8 Skip buildah-bud test 10382d0bc Skip buildx test with VFS podman storage driver dd51b62b7 Skip 'podman kube --network' test for rootless CGv1 197529f08 Skip tests which fail with CGv1 & runc 5b4f248a8 Skip rootless CGv1 quadlet tests due to issue e19922d09 Makefile: Define SHELL 43eb35a77 Machine refactor for QEMU/AppleHV e838ad86b machine refactoring preparations for hyperv b4471c6ed [CI:BUILD] spec.rpkg: trim dependency list 12153da83 Logs follow-until tests: loosen checks 7d17ec07f [CI:DOCS] Windows/Mac docs link update 7f5fc04b4 Doc update for docker network options via CLI 4b4b423b6 compat API: network create return 409 for duplicate 40f21da0c Apply suggestions to man page adacd3b12 vendor c/common@852ca05a1fbb 6a3757b73 Quadlet: Add support for LogDriver key in container and kube units ebb45b5bd machine refactoring preparations for hyperv af8d649da libpod: always use direct mapping 9dc730d9f netavark: only use aardvark ip as nameserver e9942c61d build(deps): bump github.com/container-orchestrated-devices/container-device-interface 79a05ca2b podman logs passthrough driver support --cgroups=split d7e96536e journald logs: simplify entry parsing 1590c7bf4 podman logs: read journald with passthrough 5754df806 make docs: sanity check for broken man pages 5056bd45f build(deps): bump github.com/vbauerster/mpb/v8 from 8.1.6 to 8.2.0 5fcd2c3fa build(deps): bump github.com/onsi/gomega from 1.27.0 to 1.27.1 2659a3228 kube: rm secret on down, print secret on play 9ce589a4a Fix spacing typo that triggered OCD & indent units in podman-systemd.unit(5) ad866fecb Update remote_client.md e74f60dee [CI:DOCS] Add restriction to option README 975b096bc Revert "CI: Temporarily disable all AWS EC2-based tasks" 22a207d45 build(deps): bump github.com/onsi/gomega from 1.26.0 to 1.27.0 c95978f60 kube play: only enforce passthrough in Quadlet 21cddd723 journald: remove initializeJournal() 6dd797844 auto-update: support pods 9622d25be Emergency fix for man pages: check for broken includes c81fbd5d0 System tests: assert(): friendlier failure messages 761da776a Cirrus: Fix version-check to only run on `main` job 7f8bc6f51 CI: Temporarily disable all AWS EC2-based tasks 6f5ca7318 build(deps): bump github.com/containerd/containerd from 1.6.16 to 1.6.18 6ca857feb volume,container: chroot to source before exporting content 94d4b5278 Support sysctl configs via podman kube play 510e44359 [CI:BUILD] copr: podman.spec.rpkg cleanups a4677405c quadlet system tests: add useful defaults, logging 96af9e4e0 libpod: support relative positions for idmaps c7ee65596 Experimental workaround for cdn03.quay.io flake 86e55d0ec system tests: prevent leading tabs 9abe8c785 Introduce podman machine os apply 828708bac create: add support for --group-entry 33a918711 fix != filter in volume prune 4c5b79120 Allow specification of podman --remote build -f - 3d8936642 Quadlet use crun specified in containers.conf 9f84b9b52 build(deps): bump golang.org/x/net from 0.6.0 to 0.7.0 86a4c6b65 Vendor c/image after containers/image#1847 c0f983db8 Don't set hostPort when generating a service 3a9d14d4e man page --format xref: tighten the autocompletion check 0999991b2 add support for limiting tmpfs size for systemd-specific mnts 9a1f47887 build(deps): bump golang.org/x/text from 0.6.0 to 0.7.0 35d16ea02 Add ulimit annotation to kube gen & play 34d412e13 man page xref: validate displayed man page names 7c54d1423 quadlet: add ExecStop d2ac85f7a install sigproxy before start/attach 191e4ce40 build(deps): bump golang.org/x/tools from 0.5.0 to 0.6.0 in /test/tools a5ca73225 Fix typos 45fb353f4 Cirrus: Make benchmarks .env file easier to load a7db3e8d2 Cirrus: Omit functions in env. file 1541ce56c kube play: set service container as main PID when possible 08e13867a Fix typos. Improve language. 9cba0474b events + container inspect test: RHEL fixes 5a9074dab Add ctrName to network alias during kube play 586515976 Run codespell on codebase c7619c8ae podman image scp: added identity for ssh.Exec fb54be2e1 [CI:DOCS] Clarify nomap constrains 433413549 [CI:DOCS] man-page checker: include --format (Go templates) e308ba021 Vendor c/image after containers/image#1816 ec4ab08c8 [CI:DOCS] Cleanup some man pages to display options with line breaks 5ed217409 [CI:DOCS] Add tables to podman-systemd.unit man page 3de409ad6 github: remove prefix from bugs/features d6dd17fdf Quadlet: Add support for the Secret key in Container group 08d28bfc2 [CI:DOCS] OWNERS: add @ygalblum and @alexlarsson 47df0ca25 build(deps): bump golang.org/x/term from 0.4.0 to 0.5.0 ded44be16 build(deps): bump github.com/vbauerster/mpb/v8 from 8.1.4 to 8.1.6 42c7c59dd Sort quadlet keys to make it easier to read 43b357068 e2e: fix some tests on remote 83367a6b3 kube play: do not teardown unconditionally on error ac71fa01c Fix typos in comments 6b6458916 Resolve symlink path for qemu directory if possible 90eb834e7 #17363 Fix contradicting documentation podman-commit 1916da596 Fix a potential UID/GID collision in unit tests 93c35a703 golangci-lint: show all errors at once 77e4b1939 update golangci-lint to version 1.51.1 1fd0ce71d [CI:DOCS] events: document journald identifiers f1352521f Quadlet: exit 0 when there are no files to process ced934284 network ls: handle removed container 315215020 e2e: adapt play kube test on remote rootless 4e8906c5e docs/podman-systemd.unit: Explicitely mention network & kube units c4f338eec docs/podman-systemd.unit: Update example to work out of the box 50f72fe7b [CI:BUILD] Cirrus: Fix GraphQL ownerRepository:null error 83a0e97ab Add missing return after errors 84c674fee Revert "Cirrus: Emergency fix to un-stuck PRs" af0f10a22 pasta: Fix ICMPv6 Echo test, skip it for the moment 859579b6b pasta: Fix ICMP Echo Request (IPv4) test e33f4e0bc pasta: Use two connections instead of three in TCP range forward tests acaab3fa7 Add SELinux label types support to quadlet 928d589b7 Add quadlet support for rootfs= containers 6b3073f53 Cirrus: Emergency fix to un-stuck PRs 8441f01be Move clean-binaries before podman-remote in podman-remote-docs target aa0d4b266 oci: bind mount /sys with --userns=(auto|pod:) e6904f6f8 Cleanup podman-systemd.unit file 3c3526e53 Install podman-systemd.unit man page, make quadlet discoverable de63ad704 libpod: allow userns=keep-id for root 9e7f1bea4 system-reset: use CleanCacheMount to clear build cache 5ca35d6de vendor: bump buildah to v1.29.1-0.20230201192322-e56eb25575c7 3ce07b556 system tests: fix noexistent labels test in the remote a909e2f2d Expose Podman named pipe in Inspect output 2bb4c7cdd libpod: support idmap for --rootfs ed1f76917 test: adapt test to work on cgroupv1 ed18cdd6e Bump to v4.5.0-dev b6d91ebfb Update main to reflect v4.4.0 release be47eeb85 Update from /github.com/vbauerster/mpb/v7 to /v8 8aa377698 hack/perf: cleanup after benchmarks cb5a9e9f4 hack/perf/bz-2162111.sh: use custom network a1436d8fb Update bug_report.yaml 02bcf0bac Handle filetype field in kubernetes.yaml files 1a786ea53 hack/perf/bz-2162111.sh: measure stop bd8937c50 make hack/markdown-preprocess parallel-safe 68371ff55 system tests: fix volume exec/noexec test f69efb6ee system tests: minor fix for RHEL8 incompatibility cf7afed05 Cirrus: Use versionable IMAGE_SUFFIX cbb45a6d4 utils: new conversion method 0e949bfd3 libpod: use GraphRoot for overlay upper dir 427d69cc3 vendor: update containers/storage d10860a32 Do not mount /dev/tty into rootless containers 5c059e3ed build(deps): bump go.etcd.io/bbolt from 1.3.6 to 1.3.7 9272cabd3 e2e: fix run_staticip_test about no_proxy 2e397120d docs: specify order preference for FROM 15594e92e Fixes port collision issue on use of --publish-all 952049fe5 Support for Windows paths in the source position of the volume mounts 0e3524b8b e2e tests: fix incorrect os.User.Name 7c60a784c Log data that we failed to unmarshal 61db1d5aa [CI:DOCS] hack/perf: add script for BZ 216111 29b346dea container rm: save once for exec removal and state change 8f2a40d81 [DOCS:CI] podman-events: document verbose create events 7e80edd3a e2e: Avoid hard-coding included in quadlet test 2682d3ad9 e2e: Avoid hard-coding ImageCacheDir 387f0ea2f Making gvproxy.exe optional for building Windows installer 74c090973 Add gvproxy to Windows packages ab8e49d74 Add comment to clarify error handling intention 12d70446f fix #17244: use /etc/timezone where `timedatectl` is missing on Linux 063e273e9 Fix usage of absolute windows paths with --image-path b0b166b5b Match VT device paths to be blocked from mounting exactly 553e53d44 Fix default handling of pids-limit 069edc3ad Add (podman {image,manifest} push --sign-by-sigstore=param-file.yaml) e51991030 journald: podman logs only show logs for current user 2ab90f2ed journald: podman events only show events for current user 21b82bb68 e2e: Remove the cache with "podman unshare rm" when a rootless user 9db657f40 Clean up more language for inclusiveness 814f7c569 e2e: Remove some directories at SynchronizedAfterSuite 497be102a fix: don't output "ago" when container is currently up and running b28519fd9 fix: running check error when podman is default in wsl a745d99a8 fix CI: test fail due to merge f3d8f6c49 Bump Bulidah to v1.29.0 38d5319f1 e2e: reduce dependency on /tmp for e2e tests 0ffce8181 Bump cirrus image with easier dependency management e62e42bfa quadlet: Add device support for .volume files 70e8f6243 remote,build: error if containerignore is symlink c74bdae35 DB: make loading container states optional 6132c4d54 ps: do not sync container 958c94094 Set runAsNonRoot=true in gen kube 7aef3301d WSL refactoring 08186d7dd kube-play: add support for HostIPC in pod.Spec 8850db961 Allow --device-cgroup-rule to be passed in by docker API Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>

@ygalblum

This version introduces envsubt in the install stage, so we add gettext-native to our build dependencies. Bumping libpod to version v4.5.0-14-gc926b12c5, which comprises the following commits: bc2f0115d [v4.5] system tests: fix race in kube-play read-only 696c2d40d api: fix parsing filters 1fa2eb53b Support systemd optional prefix '-' for devices. 74634a46c *: migrate image registry to registry.k8s.io 0fb11cccd Makefile: include `release-artifacts` target 4d2cf293e [CI:BUILD] Packit: Initial Enablement da927a75c Bump to v4.5.1-dev 75e3c1257 Release v4.5.0 32a6892b6 [CI:DOCS] Final release notes for v4.5.0 5de2a13e0 Quadlet - do not set log-driver by default c5e704c82 Return title fields as a list bf6f58b02 Bump to v4.5.0-dev f3c365887 Bump to v4.5.0-RC2 15c302533 Final release notes for v4.5.0-RC2 af7c25811 test/e2e: remove unnecessary SkipIfNetavark() calls 80652cacf test/e2e: deduplicated network test b526839a4 docs: update podman-network-create.1 ed99a979c network create: add --interface-name 676486a85 test/system/252-quadlet.bats: fix flake 1bf5bdc68 Read kube_generate_type from containers.conf 11ac0d03e Debian setup: workaround for runc /dev/char/10:200 bug 38c217a0b pkg/rootless: use catatonit from /usr/libexec/podman bab95de9a rootless: make sure we only use a single pause process 3b2b1441e Use atomic config writing strategy for podman machine config files 67307603b Add remaining release notes for v4.5.0-RC2 d53871cf1 GHA: Use version instead of SHA for actions 25bc7d161 chore(deps): update dependency containers/automation_images to v20230405 944accffa build: pass env by reference 7edf73dfd test: retrofit error message b624ad757 test/system: expect 12 char for short id 260bc3ec4 vendor: bump containers/(storage, common, buildah, image) c5a0d8646 [skip-ci] Update actions/upload-artifact action to v3 d3cf8ccf8 [skip-ci] Update actions/stale action to v8 21fbd5c1a [skip-ci] Update actions/setup-go action to v4 f3971e412 [skip-ci] Update github/issue-labeler action to v2.6 c4e79fc16 Fix up codespell errors a5dd5c20e Capitalize all uid,gid and id words that are not options in docs 352a41e3a build(deps): bump golang.org/x/tools from 0.7.0 to 0.8.0 in /test/tools 13135f924 Properly remove the service container during kube down f6a50311c quadlet: add `UserNS` option key 29aac4dfe [CI:DOCS] Release notes for 4.5.0 Part 1 358b46225 "podman pull by digest and list --all" test: untag instead of rmi f417861e0 build(deps): bump golang.org/x/text from 0.8.0 to 0.9.0 43e6bc9d9 Add renovate.json configuration cf6f13704 CI: postbuild step: skip under nightly treadmill db9785ba5 The `--ulimit` option accepts the name with an `RLIMIT_` prefix both upper and lower case dc9a65e34 test/e2e: use custom network config dir where needed 35165df37 chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` b858c7e7f update completion scripts for cobra v1.7.0 e4aad8f0f libpod.storageService.CreateContainerStorage(): retrieve ID maps d0ffb8792 Fix invalid pod name and hostname during kube generate 761eca9e7 e2e tests: fix racy flakes 56e7b511e Cirrus: Enable labeling of EC2 VMs 74f9fd8e6 Cirrus: Fix aarch64 clone_script 404 errors ce8a3a0c1 e2e: GinkgoParallelNode() -> ...Process() 45b1099ef build(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0 34a5c7f15 build(deps): bump golang.org/x/sys from 0.6.0 to 0.7.0 10d2e9fde [CI:DOCS] --creds and registries 9b7fd3936 Copr: fix build deps for /usr/bin/envsubst 80f9f8077 Don't error when removing non-existant env vars ecce01e61 e2e: healthcheck on stopped container: fix flake cb7b8fb31 test/apiv2/80-kube.at e1be7d141 test/apiv2/80-kube.at 1f3ae8a4f system service: do not close Body bb70d60f1 rm `hack/release.sh` 704901d11 build(deps): bump github.com/onsi/gomega from 1.27.5 to 1.27.6 243ca7c28 add `quadlet -version` flag 7eb78f8a7 add version/rawversion package 53b16ccd2 quadlet: use `Flag` suffix for variables 443f8d89c quadlet: implement `Tmpfs` option 91ca15e96 Bump to v4.5.0-dev 3e48017d8 Bump to 4.5.0-rc1 b7175a366 Update release notes from 4.4 branch 2051e54e0 rootless netns: recover from invalid netns 99ace1908 System tests: unverbosify a flake log 68dbddd97 Add support for secret exists 78e7ade0d Fix Win install task failures with large PR bodies 21febcb5c docs: add `starting` to `HealthCheckResults.Status` d7051d745 Add support for cgroup_config from containers.conf 4d56292e7 libpod: mount safely subpaths 4f9019406 Support Deployment generation with kube generate 8b6a7c182 Use secret.items to create volume mounts if present 359f40869 [CI:DOCS] fix typo in --systemd option 266cc7882 rootless: drop preexec hook error message 3c9ce3e52 Edit the docker wrapper to use the install prefix 5643058c8 Update podman-for-windows.md d79519e70 Quadlet: RemapUsers documentation fixes 7f8d5e565 speed up image listing f0cfbbe2c vendor containers/common@e27c30ee9b1b 70abb4ae5 fix volume-plugin-test flake b3e8791f6 Document building Podman remote on Windows hosts c40eaa242 test/e2e: gpg keep stdout/err attached f131eaa74 auto-update: stop+start instead of restart sytemd units b7a8e1285 [CI:DOCS] Improve basic tutorial be7827c7e Update docs/source/markdown/podman-network.1.md c335ff241 Add debug to --wait test 81e5bffc3 fix slirp4netns resolv.conf ip with a userns 11e5c2d0f Quadlet: add support for keep-id with mapping values b5df38c23 Quadlet E2E test - run quadlet as user generator cdb5b3e99 sqlite: do not `Ping()` after connecting da96ff6cc Quadlet - treat paths starting with systemd specifiers as absolute dd8ee49f6 Update docs/source/markdown/podman-kube-play.1.md.in d85c8d7e8 system tests: use CONTAINERS_CONF_OVERRIDE 51d068ecc implement podman machine set for hyperv 46b826a90 [CI:DOCS] Add network subnets info to network man page dd8574022 CI: retry the golangci install 92e0efc5d system tests: fix racey sdnotify test 518eafaa3 hyperv: lookup machine on local filesystem first 4c72fc26b fix os.IsNotExist() CI check 7daab31f1 Ensure that SQLite state handles name-ID collisions 64ba82601 macos pkginstaller: do not fail when podman-mac-helper fails 4f3cbf15c podman-mac-helper: install: do not error if already installed ade46ae6a build(deps): bump github.com/onsi/gomega from 1.27.4 to 1.27.5 e061cb968 Fix a race around SQLite DB config validation c5fc44582 add CONTAINERS_CONF_OVERRIDE 5f86fae71 vendor containers/common@main 6825740fc docs: minor grammar fix in `--volume` description b31d9e15f sqlite: do not use shared cache 9be4a525f test: podman checkpoint/restore the latest container 5185e7e39 stats compat API: return "id" lowercase 5f274e45f Run make codespell 3925cd653 Drop SQLite max connections 0fbc32515 sqlite: set connection attributes on open 9f0e0e833 Fix database locked errors with SQLite cf5df5b80 quadlet tests: skip on RHEL8 rootless cb24d6c3d Kube Play Doc: Document the support for K8S Secret 6b2101bc7 New ulimit test: bump up minimum nfiles 5447e88b4 logformatter: hide --db-backend, and friendlyize quadlet 5382997e0 Quadlet - add support for relative path in Volume key in .container file 3e405a2fd Add service ctr cleanup to PlayKubeDown 956341543 fix --health-on-failure=restart in transient unit 26d5df77d Quadlet Doc: Suggest the kill operation for HealthOnFailure 5d1342fc5 Quadlet - Add support for health checks configuration in .container files 3ef707def Makefile: allow specifying /lib dir location a5abbdf1f Fix option --opts -> --opt 0dac214f5 basic hypverv machine implementation 94f905a50 Fix SQLite DB schema migration code 46d165040 Add support for oom_score_adj value from containers.conf 6046832f3 Use default_ulimits field in containers.conf e2d49fb65 CI: test and confirm DESIRED_DATABASE 1ea62f32f build(deps): bump github.com/openshift/imagebuilder 526dfb893 logformatter: futureproof output filename e21cf2d8d Vendor in latest containers/(storage, common, image) 686bdcc29 build(deps): bump google.golang.org/protobuf from 1.29.0 to 1.30.0 ba141adce test/system/255-auto-update.bats: add debug logs c2a24abc0 Revert "Revert "pasta: Use two connections instead of three in TCP range forward tests"" 3a59af219 Add information for secret inspect 87e93a7b6 Add format to podman volume ls b424f8fb0 Add format to podman volume inspect 2555c8034 Add format to podman secret ls 1c4bd4a73 Add format to podman system df 71bcd9891 Add format to podman machine info 581611844 Add format table to podman image inspect man page e92955245 Cirrus: Store podman machine benchmark data b3035b9d6 Update Cirrus display names, and fix get-ci-vm script 6142c16a9 Ensure SQLite places uses the runroot in transient mode 2ec11b16a Fix various integration test issues with SQLite state 0f8530b1e Remove test for pod/container name global uniqueness 6e0f11da5 Improve handling of existing container names in SQLite 39fd9aa08 Add SQLite job to CI 7ed1c7fd9 buildah treadmill: also run rootless tests 2b4a27719 build(deps): bump github.com/vbatts/git-validation in /test/tools 3c51b61d7 auto update: return restart error ea2a0767a fix: Document removing anonymous volumes 408e764b9 events: no duplicates when streaming during a log rotation 82f2f8258 Add search --cert-dir, --creds bae07b6ea podman-mac-helper: exit 1 on error 7d8d3e810 system service --log-level=trace: support hijack eed389508 test/system: fix wait_for_port() to wait for bind 2d1f4a8bf cgroupns: private cgroupns on cgroupv1 breaks --systemd 01fd5bcc3 libpod: remove error stutter 4562e61d2 podman events: unhide --stream 7a7af735a test/system/255-auto-update.bats: multiple services 40d0d233e 255-auto-update.bats: turn off rollback where needed a9d70e9fe Use append() to add elements to a slice 1c08f2eda Revert "pasta: Use two connections instead of three in TCP range forward tests" ad8a96ab9 Support running nested SELinux container separation 159936a11 bud tests: rootless remote: use correct socket path 6f9f395b3 build(deps): bump github.com/vbauerster/mpb/v8 from 8.2.1 to 8.3.0 bad41f67e compat: /auth: parse server address correctly 6363fb08f docs: fix cmd `set DOCKER_HOST` suggestion fb4f6f95c test: reenable idmap test b5a99e081 Must use mountlabel when creating builtin volumes 8d952c01d podman.spec.rpkg: distro conditionals for modulesloaddir 9294b7350 build(deps): bump google.golang.org/protobuf from 1.28.1 to 1.29.0 21651706e podman inspect list network when using --net=host or none f928cf54a pasta: Re-enable "Local forwarder, IPv4" test, accept NXDOMAIN as response 829e910cd build(deps): bump golang.org/x/tools from 0.6.0 to 0.7.0 in /test/tools cc7a1e614 CI: Switch to c20230307t192532z-f37f36d12 images 799c20177 Cirrus: Run system & integration tests in parallel c03cb5718 Update checkpointctl v0.1.0 cb3cda55f Quadlet: add support for setting --ip and --ip6 af7a759e9 build(deps): bump golang.org/x/net from 0.7.0 to 0.8.0 5d039ce22 build(deps): bump golang.org/x/sys from 0.5.0 to 0.6.0 34ff27b81 libpod: avoid nil pointer dereference in (*Container).Cleanup 25dd4d653 [CI:DOCS] Add image not found info to troubleshooting 0498ce3a5 cmd: do not require userns for "version" 2860d55c9 cmd: drop special handling for "scp" da04469f0 cmd: clarify meaning of ParentNSRequired 0ab4b2614 Fix package restore 0d219486f [CI:DOCS] Fix docs/version-check always requesting updates e77f370f8 sqlite: add a hidden --db-backend flag cca65db01 fix: update the default machine value when the previously set default machine is deleted 9ac0d4f1a podman machine: Adjust Chrony makestep config 2c67ff5d4 sqlite: add container short ID to network aliases 38acab832 sqlite: remove dead code 2342d1a31 sqlite: addContainer: add named volume only once 86d12520e sqlite: implement RewriteVolumeConfig df88f546b sqlite: LookupVolume: fix partial name match 01359457c sqlite: LookupVolume: wrap error 69ff04f73 sqlite: fix type rewriting container config e87014e44 sqlite: return correct error on pod-name conflict 84b5c6c71 sqlite: RewritePodConfig: update error message 51cf2dd36 test/system/255-auto-update.bats: wait 10 for update to finish b727f30ac auto-update test: wait for service to be ready 76056c670 Vendor in latest containers/(common, storage, image) 20a42d0e4 play kube: Add --wait option 6babef598 Cirrus: Fix git config permission denied ccc5aa59a Quadlet: Add support for the Mount key in .container files 6f09dbc2d build(deps): bump github.com/onsi/gomega from 1.27.1 to 1.27.2 77861d6af fix "podman logs --since --follow" flake 6d352dc0b Clarify that replicas are ignored in kubernetes deployment 42540a667 Revert "Skip all pasta tests" e804ddc5a CI: Switch to c20230223t153813z-f37f36d12 images 070572245 Fix user socket path 1e516e657 pkginstaller: bump Qemu to version 7.2.0 0f92e19e8 Cirrus: Fix bud tests failing to apply patches 1ef8a860c build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2 b00874c16 build(deps): bump github.com/coreos/stream-metadata-go 9d93486d2 Vendor in latest containers/storage d838c08b3 buildah-bud tests: don't sudo when rootless is desired 1f6f81f5d Temporarily disable version-check 5a08ddaec CI: new rootless buildah-bud tests (cron only) 5d2d609be sqlite: fix volume lookups with partial names 495314a16 sqlite: fix container lookups with partial IDs efe7aeb1d sqlite: fix LookupPod 19c2f37ba sqlite: fix pod create/rm e32bea937 sqlite: LookupContainer: update error message 565bb5645 sqlite: AddContainerExitCode: allow to replace 4b3b94473 system: add warning when running rootless on cgroupv1 1b1cdfa35 sqlite: fix AllContainers with state 21fcc9070 sqlite: fix "UPDATE TABLE" typos 3f96b0ef2 sqlite: SaveVolume: fix syntax error updating the volumes table 7c11f7e17 sqlite: exit code: allow -1 e74f7bcaf sqlite: fix typo when removing exec sessions 560805ac4 sqlite: AllContainers: fix inner join 8c64c4370 sqlite: move migration after table creation eeabe975e sqlite: implement pod methods 0d75854c5 Quadlet - use the default runtime 49d560e1b docs: context is not optional for build 03aaa8d35 Fix an incorrect comment on NewSqliteState eb228f264 Add support for containers.conf database setting 59a54f32d Add support for volume operations to SQLite state c0b92bdbc Implement exec session handling in SQL database 627a5b73b Various fixes from code review c4fe0af2a Remove `--namespace` flag from Podman root 89d0ccd19 Get E2E tests to pass 97499a70a Implement network disconnect for SQLite state 939a4ccef Implement Network Connect/Modify for SQLite state 8ab18d848 Fix various lint issues b4c4f9c93 Some further work on SQLite state 5c2a0670f Remove concept of Namespaces from BoltDB 1b968c607 Add initial SQLite-backed state implementation 93e7cc119 Cirrus: Support runc testing on debian VMs 81f116c59 Skip all pasta tests 642e9ddb8 Skip buildah-bud test 10382d0bc Skip buildx test with VFS podman storage driver dd51b62b7 Skip 'podman kube --network' test for rootless CGv1 197529f08 Skip tests which fail with CGv1 & runc 5b4f248a8 Skip rootless CGv1 quadlet tests due to issue e19922d09 Makefile: Define SHELL 43eb35a77 Machine refactor for QEMU/AppleHV e838ad86b machine refactoring preparations for hyperv b4471c6ed [CI:BUILD] spec.rpkg: trim dependency list 12153da83 Logs follow-until tests: loosen checks 7d17ec07f [CI:DOCS] Windows/Mac docs link update 7f5fc04b4 Doc update for docker network options via CLI 4b4b423b6 compat API: network create return 409 for duplicate 40f21da0c Apply suggestions to man page adacd3b12 vendor c/common@852ca05a1fbb 6a3757b73 Quadlet: Add support for LogDriver key in container and kube units ebb45b5bd machine refactoring preparations for hyperv af8d649da libpod: always use direct mapping 9dc730d9f netavark: only use aardvark ip as nameserver e9942c61d build(deps): bump github.com/container-orchestrated-devices/container-device-interface 79a05ca2b podman logs passthrough driver support --cgroups=split d7e96536e journald logs: simplify entry parsing 1590c7bf4 podman logs: read journald with passthrough 5754df806 make docs: sanity check for broken man pages 5056bd45f build(deps): bump github.com/vbauerster/mpb/v8 from 8.1.6 to 8.2.0 5fcd2c3fa build(deps): bump github.com/onsi/gomega from 1.27.0 to 1.27.1 2659a3228 kube: rm secret on down, print secret on play 9ce589a4a Fix spacing typo that triggered OCD & indent units in podman-systemd.unit(5) ad866fecb Update remote_client.md e74f60dee [CI:DOCS] Add restriction to option README 975b096bc Revert "CI: Temporarily disable all AWS EC2-based tasks" 22a207d45 build(deps): bump github.com/onsi/gomega from 1.26.0 to 1.27.0 c95978f60 kube play: only enforce passthrough in Quadlet 21cddd723 journald: remove initializeJournal() 6dd797844 auto-update: support pods 9622d25be Emergency fix for man pages: check for broken includes c81fbd5d0 System tests: assert(): friendlier failure messages 761da776a Cirrus: Fix version-check to only run on `main` job 7f8bc6f51 CI: Temporarily disable all AWS EC2-based tasks 6f5ca7318 build(deps): bump github.com/containerd/containerd from 1.6.16 to 1.6.18 6ca857feb volume,container: chroot to source before exporting content 94d4b5278 Support sysctl configs via podman kube play 510e44359 [CI:BUILD] copr: podman.spec.rpkg cleanups a4677405c quadlet system tests: add useful defaults, logging 96af9e4e0 libpod: support relative positions for idmaps c7ee65596 Experimental workaround for cdn03.quay.io flake 86e55d0ec system tests: prevent leading tabs 9abe8c785 Introduce podman machine os apply 828708bac create: add support for --group-entry 33a918711 fix != filter in volume prune 4c5b79120 Allow specification of podman --remote build -f - 3d8936642 Quadlet use crun specified in containers.conf 9f84b9b52 build(deps): bump golang.org/x/net from 0.6.0 to 0.7.0 86a4c6b65 Vendor c/image after containers/image#1847 c0f983db8 Don't set hostPort when generating a service 3a9d14d4e man page --format xref: tighten the autocompletion check 0999991b2 add support for limiting tmpfs size for systemd-specific mnts 9a1f47887 build(deps): bump golang.org/x/text from 0.6.0 to 0.7.0 35d16ea02 Add ulimit annotation to kube gen & play 34d412e13 man page xref: validate displayed man page names 7c54d1423 quadlet: add ExecStop d2ac85f7a install sigproxy before start/attach 191e4ce40 build(deps): bump golang.org/x/tools from 0.5.0 to 0.6.0 in /test/tools a5ca73225 Fix typos 45fb353f4 Cirrus: Make benchmarks .env file easier to load a7db3e8d2 Cirrus: Omit functions in env. file 1541ce56c kube play: set service container as main PID when possible 08e13867a Fix typos. Improve language. 9cba0474b events + container inspect test: RHEL fixes 5a9074dab Add ctrName to network alias during kube play 586515976 Run codespell on codebase c7619c8ae podman image scp: added identity for ssh.Exec fb54be2e1 [CI:DOCS] Clarify nomap constrains 433413549 [CI:DOCS] man-page checker: include --format (Go templates) e308ba021 Vendor c/image after containers/image#1816 ec4ab08c8 [CI:DOCS] Cleanup some man pages to display options with line breaks 5ed217409 [CI:DOCS] Add tables to podman-systemd.unit man page 3de409ad6 github: remove prefix from bugs/features d6dd17fdf Quadlet: Add support for the Secret key in Container group 08d28bfc2 [CI:DOCS] OWNERS: add @ygalblum and @alexlarsson 47df0ca25 build(deps): bump golang.org/x/term from 0.4.0 to 0.5.0 ded44be16 build(deps): bump github.com/vbauerster/mpb/v8 from 8.1.4 to 8.1.6 42c7c59dd Sort quadlet keys to make it easier to read 43b357068 e2e: fix some tests on remote 83367a6b3 kube play: do not teardown unconditionally on error ac71fa01c Fix typos in comments 6b6458916 Resolve symlink path for qemu directory if possible 90eb834e7 #17363 Fix contradicting documentation podman-commit 1916da596 Fix a potential UID/GID collision in unit tests 93c35a703 golangci-lint: show all errors at once 77e4b1939 update golangci-lint to version 1.51.1 1fd0ce71d [CI:DOCS] events: document journald identifiers f1352521f Quadlet: exit 0 when there are no files to process ced934284 network ls: handle removed container 315215020 e2e: adapt play kube test on remote rootless 4e8906c5e docs/podman-systemd.unit: Explicitely mention network & kube units c4f338eec docs/podman-systemd.unit: Update example to work out of the box 50f72fe7b [CI:BUILD] Cirrus: Fix GraphQL ownerRepository:null error 83a0e97ab Add missing return after errors 84c674fee Revert "Cirrus: Emergency fix to un-stuck PRs" af0f10a22 pasta: Fix ICMPv6 Echo test, skip it for the moment 859579b6b pasta: Fix ICMP Echo Request (IPv4) test e33f4e0bc pasta: Use two connections instead of three in TCP range forward tests acaab3fa7 Add SELinux label types support to quadlet 928d589b7 Add quadlet support for rootfs= containers 6b3073f53 Cirrus: Emergency fix to un-stuck PRs 8441f01be Move clean-binaries before podman-remote in podman-remote-docs target aa0d4b266 oci: bind mount /sys with --userns=(auto|pod:) e6904f6f8 Cleanup podman-systemd.unit file 3c3526e53 Install podman-systemd.unit man page, make quadlet discoverable de63ad704 libpod: allow userns=keep-id for root 9e7f1bea4 system-reset: use CleanCacheMount to clear build cache 5ca35d6de vendor: bump buildah to v1.29.1-0.20230201192322-e56eb25575c7 3ce07b556 system tests: fix noexistent labels test in the remote a909e2f2d Expose Podman named pipe in Inspect output 2bb4c7cdd libpod: support idmap for --rootfs ed1f76917 test: adapt test to work on cgroupv1 ed18cdd6e Bump to v4.5.0-dev b6d91ebfb Update main to reflect v4.4.0 release be47eeb85 Update from /github.com/vbauerster/mpb/v7 to /v8 8aa377698 hack/perf: cleanup after benchmarks cb5a9e9f4 hack/perf/bz-2162111.sh: use custom network a1436d8fb Update bug_report.yaml 02bcf0bac Handle filetype field in kubernetes.yaml files 1a786ea53 hack/perf/bz-2162111.sh: measure stop bd8937c50 make hack/markdown-preprocess parallel-safe 68371ff55 system tests: fix volume exec/noexec test f69efb6ee system tests: minor fix for RHEL8 incompatibility cf7afed05 Cirrus: Use versionable IMAGE_SUFFIX cbb45a6d4 utils: new conversion method 0e949bfd3 libpod: use GraphRoot for overlay upper dir 427d69cc3 vendor: update containers/storage d10860a32 Do not mount /dev/tty into rootless containers 5c059e3ed build(deps): bump go.etcd.io/bbolt from 1.3.6 to 1.3.7 9272cabd3 e2e: fix run_staticip_test about no_proxy 2e397120d docs: specify order preference for FROM 15594e92e Fixes port collision issue on use of --publish-all 952049fe5 Support for Windows paths in the source position of the volume mounts 0e3524b8b e2e tests: fix incorrect os.User.Name 7c60a784c Log data that we failed to unmarshal 61db1d5aa [CI:DOCS] hack/perf: add script for BZ 216111 29b346dea container rm: save once for exec removal and state change 8f2a40d81 [DOCS:CI] podman-events: document verbose create events 7e80edd3a e2e: Avoid hard-coding included in quadlet test 2682d3ad9 e2e: Avoid hard-coding ImageCacheDir 387f0ea2f Making gvproxy.exe optional for building Windows installer 74c090973 Add gvproxy to Windows packages ab8e49d74 Add comment to clarify error handling intention 12d70446f fix #17244: use /etc/timezone where `timedatectl` is missing on Linux 063e273e9 Fix usage of absolute windows paths with --image-path b0b166b5b Match VT device paths to be blocked from mounting exactly 553e53d44 Fix default handling of pids-limit 069edc3ad Add (podman {image,manifest} push --sign-by-sigstore=param-file.yaml) e51991030 journald: podman logs only show logs for current user 2ab90f2ed journald: podman events only show events for current user 21b82bb68 e2e: Remove the cache with "podman unshare rm" when a rootless user 9db657f40 Clean up more language for inclusiveness 814f7c569 e2e: Remove some directories at SynchronizedAfterSuite 497be102a fix: don't output "ago" when container is currently up and running b28519fd9 fix: running check error when podman is default in wsl a745d99a8 fix CI: test fail due to merge f3d8f6c49 Bump Bulidah to v1.29.0 38d5319f1 e2e: reduce dependency on /tmp for e2e tests 0ffce8181 Bump cirrus image with easier dependency management e62e42bfa quadlet: Add device support for .volume files 70e8f6243 remote,build: error if containerignore is symlink c74bdae35 DB: make loading container states optional 6132c4d54 ps: do not sync container 958c94094 Set runAsNonRoot=true in gen kube 7aef3301d WSL refactoring 08186d7dd kube-play: add support for HostIPC in pod.Spec 8850db961 Allow --device-cgroup-rule to be passed in by docker API Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>

@ygalblum

This version introduces envsubt in the install stage, so we add gettext-native to our build dependencies. Bumping libpod to version v4.5.0-14-gc926b12c5, which comprises the following commits: bc2f0115d [v4.5] system tests: fix race in kube-play read-only 696c2d40d api: fix parsing filters 1fa2eb53b Support systemd optional prefix '-' for devices. 74634a46c *: migrate image registry to registry.k8s.io 0fb11cccd Makefile: include `release-artifacts` target 4d2cf293e [CI:BUILD] Packit: Initial Enablement da927a75c Bump to v4.5.1-dev 75e3c1257 Release v4.5.0 32a6892b6 [CI:DOCS] Final release notes for v4.5.0 5de2a13e0 Quadlet - do not set log-driver by default c5e704c82 Return title fields as a list bf6f58b02 Bump to v4.5.0-dev f3c365887 Bump to v4.5.0-RC2 15c302533 Final release notes for v4.5.0-RC2 af7c25811 test/e2e: remove unnecessary SkipIfNetavark() calls 80652cacf test/e2e: deduplicated network test b526839a4 docs: update podman-network-create.1 ed99a979c network create: add --interface-name 676486a85 test/system/252-quadlet.bats: fix flake 1bf5bdc68 Read kube_generate_type from containers.conf 11ac0d03e Debian setup: workaround for runc /dev/char/10:200 bug 38c217a0b pkg/rootless: use catatonit from /usr/libexec/podman bab95de9a rootless: make sure we only use a single pause process 3b2b1441e Use atomic config writing strategy for podman machine config files 67307603b Add remaining release notes for v4.5.0-RC2 d53871cf1 GHA: Use version instead of SHA for actions 25bc7d161 chore(deps): update dependency containers/automation_images to v20230405 944accffa build: pass env by reference 7edf73dfd test: retrofit error message b624ad757 test/system: expect 12 char for short id 260bc3ec4 vendor: bump containers/(storage, common, buildah, image) c5a0d8646 [skip-ci] Update actions/upload-artifact action to v3 d3cf8ccf8 [skip-ci] Update actions/stale action to v8 21fbd5c1a [skip-ci] Update actions/setup-go action to v4 f3971e412 [skip-ci] Update github/issue-labeler action to v2.6 c4e79fc16 Fix up codespell errors a5dd5c20e Capitalize all uid,gid and id words that are not options in docs 352a41e3a build(deps): bump golang.org/x/tools from 0.7.0 to 0.8.0 in /test/tools 13135f924 Properly remove the service container during kube down f6a50311c quadlet: add `UserNS` option key 29aac4dfe [CI:DOCS] Release notes for 4.5.0 Part 1 358b46225 "podman pull by digest and list --all" test: untag instead of rmi f417861e0 build(deps): bump golang.org/x/text from 0.8.0 to 0.9.0 43e6bc9d9 Add renovate.json configuration cf6f13704 CI: postbuild step: skip under nightly treadmill db9785ba5 The `--ulimit` option accepts the name with an `RLIMIT_` prefix both upper and lower case dc9a65e34 test/e2e: use custom network config dir where needed 35165df37 chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` b858c7e7f update completion scripts for cobra v1.7.0 e4aad8f0f libpod.storageService.CreateContainerStorage(): retrieve ID maps d0ffb8792 Fix invalid pod name and hostname during kube generate 761eca9e7 e2e tests: fix racy flakes 56e7b511e Cirrus: Enable labeling of EC2 VMs 74f9fd8e6 Cirrus: Fix aarch64 clone_script 404 errors ce8a3a0c1 e2e: GinkgoParallelNode() -> ...Process() 45b1099ef build(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0 34a5c7f15 build(deps): bump golang.org/x/sys from 0.6.0 to 0.7.0 10d2e9fde [CI:DOCS] --creds and registries 9b7fd3936 Copr: fix build deps for /usr/bin/envsubst 80f9f8077 Don't error when removing non-existant env vars ecce01e61 e2e: healthcheck on stopped container: fix flake cb7b8fb31 test/apiv2/80-kube.at e1be7d141 test/apiv2/80-kube.at 1f3ae8a4f system service: do not close Body bb70d60f1 rm `hack/release.sh` 704901d11 build(deps): bump github.com/onsi/gomega from 1.27.5 to 1.27.6 243ca7c28 add `quadlet -version` flag 7eb78f8a7 add version/rawversion package 53b16ccd2 quadlet: use `Flag` suffix for variables 443f8d89c quadlet: implement `Tmpfs` option 91ca15e96 Bump to v4.5.0-dev 3e48017d8 Bump to 4.5.0-rc1 b7175a366 Update release notes from 4.4 branch 2051e54e0 rootless netns: recover from invalid netns 99ace1908 System tests: unverbosify a flake log 68dbddd97 Add support for secret exists 78e7ade0d Fix Win install task failures with large PR bodies 21febcb5c docs: add `starting` to `HealthCheckResults.Status` d7051d745 Add support for cgroup_config from containers.conf 4d56292e7 libpod: mount safely subpaths 4f9019406 Support Deployment generation with kube generate 8b6a7c182 Use secret.items to create volume mounts if present 359f40869 [CI:DOCS] fix typo in --systemd option 266cc7882 rootless: drop preexec hook error message 3c9ce3e52 Edit the docker wrapper to use the install prefix 5643058c8 Update podman-for-windows.md d79519e70 Quadlet: RemapUsers documentation fixes 7f8d5e565 speed up image listing f0cfbbe2c vendor containers/common@e27c30ee9b1b 70abb4ae5 fix volume-plugin-test flake b3e8791f6 Document building Podman remote on Windows hosts c40eaa242 test/e2e: gpg keep stdout/err attached f131eaa74 auto-update: stop+start instead of restart sytemd units b7a8e1285 [CI:DOCS] Improve basic tutorial be7827c7e Update docs/source/markdown/podman-network.1.md c335ff241 Add debug to --wait test 81e5bffc3 fix slirp4netns resolv.conf ip with a userns 11e5c2d0f Quadlet: add support for keep-id with mapping values b5df38c23 Quadlet E2E test - run quadlet as user generator cdb5b3e99 sqlite: do not `Ping()` after connecting da96ff6cc Quadlet - treat paths starting with systemd specifiers as absolute dd8ee49f6 Update docs/source/markdown/podman-kube-play.1.md.in d85c8d7e8 system tests: use CONTAINERS_CONF_OVERRIDE 51d068ecc implement podman machine set for hyperv 46b826a90 [CI:DOCS] Add network subnets info to network man page dd8574022 CI: retry the golangci install 92e0efc5d system tests: fix racey sdnotify test 518eafaa3 hyperv: lookup machine on local filesystem first 4c72fc26b fix os.IsNotExist() CI check 7daab31f1 Ensure that SQLite state handles name-ID collisions 64ba82601 macos pkginstaller: do not fail when podman-mac-helper fails 4f3cbf15c podman-mac-helper: install: do not error if already installed ade46ae6a build(deps): bump github.com/onsi/gomega from 1.27.4 to 1.27.5 e061cb968 Fix a race around SQLite DB config validation c5fc44582 add CONTAINERS_CONF_OVERRIDE 5f86fae71 vendor containers/common@main 6825740fc docs: minor grammar fix in `--volume` description b31d9e15f sqlite: do not use shared cache 9be4a525f test: podman checkpoint/restore the latest container 5185e7e39 stats compat API: return "id" lowercase 5f274e45f Run make codespell 3925cd653 Drop SQLite max connections 0fbc32515 sqlite: set connection attributes on open 9f0e0e833 Fix database locked errors with SQLite cf5df5b80 quadlet tests: skip on RHEL8 rootless cb24d6c3d Kube Play Doc: Document the support for K8S Secret 6b2101bc7 New ulimit test: bump up minimum nfiles 5447e88b4 logformatter: hide --db-backend, and friendlyize quadlet 5382997e0 Quadlet - add support for relative path in Volume key in .container file 3e405a2fd Add service ctr cleanup to PlayKubeDown 956341543 fix --health-on-failure=restart in transient unit 26d5df77d Quadlet Doc: Suggest the kill operation for HealthOnFailure 5d1342fc5 Quadlet - Add support for health checks configuration in .container files 3ef707def Makefile: allow specifying /lib dir location a5abbdf1f Fix option --opts -> --opt 0dac214f5 basic hypverv machine implementation 94f905a50 Fix SQLite DB schema migration code 46d165040 Add support for oom_score_adj value from containers.conf 6046832f3 Use default_ulimits field in containers.conf e2d49fb65 CI: test and confirm DESIRED_DATABASE 1ea62f32f build(deps): bump github.com/openshift/imagebuilder 526dfb893 logformatter: futureproof output filename e21cf2d8d Vendor in latest containers/(storage, common, image) 686bdcc29 build(deps): bump google.golang.org/protobuf from 1.29.0 to 1.30.0 ba141adce test/system/255-auto-update.bats: add debug logs c2a24abc0 Revert "Revert "pasta: Use two connections instead of three in TCP range forward tests"" 3a59af219 Add information for secret inspect 87e93a7b6 Add format to podman volume ls b424f8fb0 Add format to podman volume inspect 2555c8034 Add format to podman secret ls 1c4bd4a73 Add format to podman system df 71bcd9891 Add format to podman machine info 581611844 Add format table to podman image inspect man page e92955245 Cirrus: Store podman machine benchmark data b3035b9d6 Update Cirrus display names, and fix get-ci-vm script 6142c16a9 Ensure SQLite places uses the runroot in transient mode 2ec11b16a Fix various integration test issues with SQLite state 0f8530b1e Remove test for pod/container name global uniqueness 6e0f11da5 Improve handling of existing container names in SQLite 39fd9aa08 Add SQLite job to CI 7ed1c7fd9 buildah treadmill: also run rootless tests 2b4a27719 build(deps): bump github.com/vbatts/git-validation in /test/tools 3c51b61d7 auto update: return restart error ea2a0767a fix: Document removing anonymous volumes 408e764b9 events: no duplicates when streaming during a log rotation 82f2f8258 Add search --cert-dir, --creds bae07b6ea podman-mac-helper: exit 1 on error 7d8d3e810 system service --log-level=trace: support hijack eed389508 test/system: fix wait_for_port() to wait for bind 2d1f4a8bf cgroupns: private cgroupns on cgroupv1 breaks --systemd 01fd5bcc3 libpod: remove error stutter 4562e61d2 podman events: unhide --stream 7a7af735a test/system/255-auto-update.bats: multiple services 40d0d233e 255-auto-update.bats: turn off rollback where needed a9d70e9fe Use append() to add elements to a slice 1c08f2eda Revert "pasta: Use two connections instead of three in TCP range forward tests" ad8a96ab9 Support running nested SELinux container separation 159936a11 bud tests: rootless remote: use correct socket path 6f9f395b3 build(deps): bump github.com/vbauerster/mpb/v8 from 8.2.1 to 8.3.0 bad41f67e compat: /auth: parse server address correctly 6363fb08f docs: fix cmd `set DOCKER_HOST` suggestion fb4f6f95c test: reenable idmap test b5a99e081 Must use mountlabel when creating builtin volumes 8d952c01d podman.spec.rpkg: distro conditionals for modulesloaddir 9294b7350 build(deps): bump google.golang.org/protobuf from 1.28.1 to 1.29.0 21651706e podman inspect list network when using --net=host or none f928cf54a pasta: Re-enable "Local forwarder, IPv4" test, accept NXDOMAIN as response 829e910cd build(deps): bump golang.org/x/tools from 0.6.0 to 0.7.0 in /test/tools cc7a1e614 CI: Switch to c20230307t192532z-f37f36d12 images 799c20177 Cirrus: Run system & integration tests in parallel c03cb5718 Update checkpointctl v0.1.0 cb3cda55f Quadlet: add support for setting --ip and --ip6 af7a759e9 build(deps): bump golang.org/x/net from 0.7.0 to 0.8.0 5d039ce22 build(deps): bump golang.org/x/sys from 0.5.0 to 0.6.0 34ff27b81 libpod: avoid nil pointer dereference in (*Container).Cleanup 25dd4d653 [CI:DOCS] Add image not found info to troubleshooting 0498ce3a5 cmd: do not require userns for "version" 2860d55c9 cmd: drop special handling for "scp" da04469f0 cmd: clarify meaning of ParentNSRequired 0ab4b2614 Fix package restore 0d219486f [CI:DOCS] Fix docs/version-check always requesting updates e77f370f8 sqlite: add a hidden --db-backend flag cca65db01 fix: update the default machine value when the previously set default machine is deleted 9ac0d4f1a podman machine: Adjust Chrony makestep config 2c67ff5d4 sqlite: add container short ID to network aliases 38acab832 sqlite: remove dead code 2342d1a31 sqlite: addContainer: add named volume only once 86d12520e sqlite: implement RewriteVolumeConfig df88f546b sqlite: LookupVolume: fix partial name match 01359457c sqlite: LookupVolume: wrap error 69ff04f73 sqlite: fix type rewriting container config e87014e44 sqlite: return correct error on pod-name conflict 84b5c6c71 sqlite: RewritePodConfig: update error message 51cf2dd36 test/system/255-auto-update.bats: wait 10 for update to finish b727f30ac auto-update test: wait for service to be ready 76056c670 Vendor in latest containers/(common, storage, image) 20a42d0e4 play kube: Add --wait option 6babef598 Cirrus: Fix git config permission denied ccc5aa59a Quadlet: Add support for the Mount key in .container files 6f09dbc2d build(deps): bump github.com/onsi/gomega from 1.27.1 to 1.27.2 77861d6af fix "podman logs --since --follow" flake 6d352dc0b Clarify that replicas are ignored in kubernetes deployment 42540a667 Revert "Skip all pasta tests" e804ddc5a CI: Switch to c20230223t153813z-f37f36d12 images 070572245 Fix user socket path 1e516e657 pkginstaller: bump Qemu to version 7.2.0 0f92e19e8 Cirrus: Fix bud tests failing to apply patches 1ef8a860c build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2 b00874c16 build(deps): bump github.com/coreos/stream-metadata-go 9d93486d2 Vendor in latest containers/storage d838c08b3 buildah-bud tests: don't sudo when rootless is desired 1f6f81f5d Temporarily disable version-check 5a08ddaec CI: new rootless buildah-bud tests (cron only) 5d2d609be sqlite: fix volume lookups with partial names 495314a16 sqlite: fix container lookups with partial IDs efe7aeb1d sqlite: fix LookupPod 19c2f37ba sqlite: fix pod create/rm e32bea937 sqlite: LookupContainer: update error message 565bb5645 sqlite: AddContainerExitCode: allow to replace 4b3b94473 system: add warning when running rootless on cgroupv1 1b1cdfa35 sqlite: fix AllContainers with state 21fcc9070 sqlite: fix "UPDATE TABLE" typos 3f96b0ef2 sqlite: SaveVolume: fix syntax error updating the volumes table 7c11f7e17 sqlite: exit code: allow -1 e74f7bcaf sqlite: fix typo when removing exec sessions 560805ac4 sqlite: AllContainers: fix inner join 8c64c4370 sqlite: move migration after table creation eeabe975e sqlite: implement pod methods 0d75854c5 Quadlet - use the default runtime 49d560e1b docs: context is not optional for build 03aaa8d35 Fix an incorrect comment on NewSqliteState eb228f264 Add support for containers.conf database setting 59a54f32d Add support for volume operations to SQLite state c0b92bdbc Implement exec session handling in SQL database 627a5b73b Various fixes from code review c4fe0af2a Remove `--namespace` flag from Podman root 89d0ccd19 Get E2E tests to pass 97499a70a Implement network disconnect for SQLite state 939a4ccef Implement Network Connect/Modify for SQLite state 8ab18d848 Fix various lint issues b4c4f9c93 Some further work on SQLite state 5c2a0670f Remove concept of Namespaces from BoltDB 1b968c607 Add initial SQLite-backed state implementation 93e7cc119 Cirrus: Support runc testing on debian VMs 81f116c59 Skip all pasta tests 642e9ddb8 Skip buildah-bud test 10382d0bc Skip buildx test with VFS podman storage driver dd51b62b7 Skip 'podman kube --network' test for rootless CGv1 197529f08 Skip tests which fail with CGv1 & runc 5b4f248a8 Skip rootless CGv1 quadlet tests due to issue e19922d09 Makefile: Define SHELL 43eb35a77 Machine refactor for QEMU/AppleHV e838ad86b machine refactoring preparations for hyperv b4471c6ed [CI:BUILD] spec.rpkg: trim dependency list 12153da83 Logs follow-until tests: loosen checks 7d17ec07f [CI:DOCS] Windows/Mac docs link update 7f5fc04b4 Doc update for docker network options via CLI 4b4b423b6 compat API: network create return 409 for duplicate 40f21da0c Apply suggestions to man page adacd3b12 vendor c/common@852ca05a1fbb 6a3757b73 Quadlet: Add support for LogDriver key in container and kube units ebb45b5bd machine refactoring preparations for hyperv af8d649da libpod: always use direct mapping 9dc730d9f netavark: only use aardvark ip as nameserver e9942c61d build(deps): bump github.com/container-orchestrated-devices/container-device-interface 79a05ca2b podman logs passthrough driver support --cgroups=split d7e96536e journald logs: simplify entry parsing 1590c7bf4 podman logs: read journald with passthrough 5754df806 make docs: sanity check for broken man pages 5056bd45f build(deps): bump github.com/vbauerster/mpb/v8 from 8.1.6 to 8.2.0 5fcd2c3fa build(deps): bump github.com/onsi/gomega from 1.27.0 to 1.27.1 2659a3228 kube: rm secret on down, print secret on play 9ce589a4a Fix spacing typo that triggered OCD & indent units in podman-systemd.unit(5) ad866fecb Update remote_client.md e74f60dee [CI:DOCS] Add restriction to option README 975b096bc Revert "CI: Temporarily disable all AWS EC2-based tasks" 22a207d45 build(deps): bump github.com/onsi/gomega from 1.26.0 to 1.27.0 c95978f60 kube play: only enforce passthrough in Quadlet 21cddd723 journald: remove initializeJournal() 6dd797844 auto-update: support pods 9622d25be Emergency fix for man pages: check for broken includes c81fbd5d0 System tests: assert(): friendlier failure messages 761da776a Cirrus: Fix version-check to only run on `main` job 7f8bc6f51 CI: Temporarily disable all AWS EC2-based tasks 6f5ca7318 build(deps): bump github.com/containerd/containerd from 1.6.16 to 1.6.18 6ca857feb volume,container: chroot to source before exporting content 94d4b5278 Support sysctl configs via podman kube play 510e44359 [CI:BUILD] copr: podman.spec.rpkg cleanups a4677405c quadlet system tests: add useful defaults, logging 96af9e4e0 libpod: support relative positions for idmaps c7ee65596 Experimental workaround for cdn03.quay.io flake 86e55d0ec system tests: prevent leading tabs 9abe8c785 Introduce podman machine os apply 828708bac create: add support for --group-entry 33a918711 fix != filter in volume prune 4c5b79120 Allow specification of podman --remote build -f - 3d8936642 Quadlet use crun specified in containers.conf 9f84b9b52 build(deps): bump golang.org/x/net from 0.6.0 to 0.7.0 86a4c6b65 Vendor c/image after containers/image#1847 c0f983db8 Don't set hostPort when generating a service 3a9d14d4e man page --format xref: tighten the autocompletion check 0999991b2 add support for limiting tmpfs size for systemd-specific mnts 9a1f47887 build(deps): bump golang.org/x/text from 0.6.0 to 0.7.0 35d16ea02 Add ulimit annotation to kube gen & play 34d412e13 man page xref: validate displayed man page names 7c54d1423 quadlet: add ExecStop d2ac85f7a install sigproxy before start/attach 191e4ce40 build(deps): bump golang.org/x/tools from 0.5.0 to 0.6.0 in /test/tools a5ca73225 Fix typos 45fb353f4 Cirrus: Make benchmarks .env file easier to load a7db3e8d2 Cirrus: Omit functions in env. file 1541ce56c kube play: set service container as main PID when possible 08e13867a Fix typos. Improve language. 9cba0474b events + container inspect test: RHEL fixes 5a9074dab Add ctrName to network alias during kube play 586515976 Run codespell on codebase c7619c8ae podman image scp: added identity for ssh.Exec fb54be2e1 [CI:DOCS] Clarify nomap constrains 433413549 [CI:DOCS] man-page checker: include --format (Go templates) e308ba021 Vendor c/image after containers/image#1816 ec4ab08c8 [CI:DOCS] Cleanup some man pages to display options with line breaks 5ed217409 [CI:DOCS] Add tables to podman-systemd.unit man page 3de409ad6 github: remove prefix from bugs/features d6dd17fdf Quadlet: Add support for the Secret key in Container group 08d28bfc2 [CI:DOCS] OWNERS: add @ygalblum and @alexlarsson 47df0ca25 build(deps): bump golang.org/x/term from 0.4.0 to 0.5.0 ded44be16 build(deps): bump github.com/vbauerster/mpb/v8 from 8.1.4 to 8.1.6 42c7c59dd Sort quadlet keys to make it easier to read 43b357068 e2e: fix some tests on remote 83367a6b3 kube play: do not teardown unconditionally on error ac71fa01c Fix typos in comments 6b6458916 Resolve symlink path for qemu directory if possible 90eb834e7 #17363 Fix contradicting documentation podman-commit 1916da596 Fix a potential UID/GID collision in unit tests 93c35a703 golangci-lint: show all errors at once 77e4b1939 update golangci-lint to version 1.51.1 1fd0ce71d [CI:DOCS] events: document journald identifiers f1352521f Quadlet: exit 0 when there are no files to process ced934284 network ls: handle removed container 315215020 e2e: adapt play kube test on remote rootless 4e8906c5e docs/podman-systemd.unit: Explicitely mention network & kube units c4f338eec docs/podman-systemd.unit: Update example to work out of the box 50f72fe7b [CI:BUILD] Cirrus: Fix GraphQL ownerRepository:null error 83a0e97ab Add missing return after errors 84c674fee Revert "Cirrus: Emergency fix to un-stuck PRs" af0f10a22 pasta: Fix ICMPv6 Echo test, skip it for the moment 859579b6b pasta: Fix ICMP Echo Request (IPv4) test e33f4e0bc pasta: Use two connections instead of three in TCP range forward tests acaab3fa7 Add SELinux label types support to quadlet 928d589b7 Add quadlet support for rootfs= containers 6b3073f53 Cirrus: Emergency fix to un-stuck PRs 8441f01be Move clean-binaries before podman-remote in podman-remote-docs target aa0d4b266 oci: bind mount /sys with --userns=(auto|pod:) e6904f6f8 Cleanup podman-systemd.unit file 3c3526e53 Install podman-systemd.unit man page, make quadlet discoverable de63ad704 libpod: allow userns=keep-id for root 9e7f1bea4 system-reset: use CleanCacheMount to clear build cache 5ca35d6de vendor: bump buildah to v1.29.1-0.20230201192322-e56eb25575c7 3ce07b556 system tests: fix noexistent labels test in the remote a909e2f2d Expose Podman named pipe in Inspect output 2bb4c7cdd libpod: support idmap for --rootfs ed1f76917 test: adapt test to work on cgroupv1 ed18cdd6e Bump to v4.5.0-dev b6d91ebfb Update main to reflect v4.4.0 release be47eeb85 Update from /github.com/vbauerster/mpb/v7 to /v8 8aa377698 hack/perf: cleanup after benchmarks cb5a9e9f4 hack/perf/bz-2162111.sh: use custom network a1436d8fb Update bug_report.yaml 02bcf0bac Handle filetype field in kubernetes.yaml files 1a786ea53 hack/perf/bz-2162111.sh: measure stop bd8937c50 make hack/markdown-preprocess parallel-safe 68371ff55 system tests: fix volume exec/noexec test f69efb6ee system tests: minor fix for RHEL8 incompatibility cf7afed05 Cirrus: Use versionable IMAGE_SUFFIX cbb45a6d4 utils: new conversion method 0e949bfd3 libpod: use GraphRoot for overlay upper dir 427d69cc3 vendor: update containers/storage d10860a32 Do not mount /dev/tty into rootless containers 5c059e3ed build(deps): bump go.etcd.io/bbolt from 1.3.6 to 1.3.7 9272cabd3 e2e: fix run_staticip_test about no_proxy 2e397120d docs: specify order preference for FROM 15594e92e Fixes port collision issue on use of --publish-all 952049fe5 Support for Windows paths in the source position of the volume mounts 0e3524b8b e2e tests: fix incorrect os.User.Name 7c60a784c Log data that we failed to unmarshal 61db1d5aa [CI:DOCS] hack/perf: add script for BZ 216111 29b346dea container rm: save once for exec removal and state change 8f2a40d81 [DOCS:CI] podman-events: document verbose create events 7e80edd3a e2e: Avoid hard-coding included in quadlet test 2682d3ad9 e2e: Avoid hard-coding ImageCacheDir 387f0ea2f Making gvproxy.exe optional for building Windows installer 74c090973 Add gvproxy to Windows packages ab8e49d74 Add comment to clarify error handling intention 12d70446f fix #17244: use /etc/timezone where `timedatectl` is missing on Linux 063e273e9 Fix usage of absolute windows paths with --image-path b0b166b5b Match VT device paths to be blocked from mounting exactly 553e53d44 Fix default handling of pids-limit 069edc3ad Add (podman {image,manifest} push --sign-by-sigstore=param-file.yaml) e51991030 journald: podman logs only show logs for current user 2ab90f2ed journald: podman events only show events for current user 21b82bb68 e2e: Remove the cache with "podman unshare rm" when a rootless user 9db657f40 Clean up more language for inclusiveness 814f7c569 e2e: Remove some directories at SynchronizedAfterSuite 497be102a fix: don't output "ago" when container is currently up and running b28519fd9 fix: running check error when podman is default in wsl a745d99a8 fix CI: test fail due to merge f3d8f6c49 Bump Bulidah to v1.29.0 38d5319f1 e2e: reduce dependency on /tmp for e2e tests 0ffce8181 Bump cirrus image with easier dependency management e62e42bfa quadlet: Add device support for .volume files 70e8f6243 remote,build: error if containerignore is symlink c74bdae35 DB: make loading container states optional 6132c4d54 ps: do not sync container 958c94094 Set runAsNonRoot=true in gen kube 7aef3301d WSL refactoring 08186d7dd kube-play: add support for HostIPC in pod.Spec 8850db961 Allow --device-cgroup-rule to be passed in by docker API Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>

mtrmac added 5 commits February 13, 2023 19:23

Reorder bodyReader fields to separate constants and state

d39a77b

Purely aesthetic, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Turn millisecondsSince into millisecondsSinceOptional

5a2fb40

... because we will have more cases of the NaN case, so share that code path. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Only get current time once in errorIfNotReconnecting

cf65b0b

Avoid redundant work. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Rename some variables

3f60ff9

Consistently use ms... for milliseconds (durations), and ...Time for timestamps. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Also record, and output, the time of last retry, if any

213718c

This will be used for more heuristics. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

mtrmac mentioned this pull request Feb 13, 2023

copying system image from manifest list: writing/storing blob: happened during read: unexpected EOF containers/podman#17193

Open

Relax retry heuristics

f864ed7

Even if we didn't make much progress, allow one retry per minute anyway. Notably this allows one retry ~immediately, we see failures a few dozen milliseconds after the connection is set up. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

mtrmac force-pushed the eof2 branch from 988478b to f864ed7 Compare February 13, 2023 19:03

mtrmac added 2 commits February 13, 2023 22:23

Differentiate between no retry and immediate retry also in the printe…

3bf5378

…d offset Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Add unit tests for the retry heuristics

02d5fc5

Signed-off-by: Miloslav Trmač <mitr@redhat.com>

rhatdan reviewed Feb 14, 2023

View reviewed changes

vrothberg approved these changes Feb 14, 2023

View reviewed changes

rhatdan merged commit ae0edb7 into containers:main Feb 14, 2023

mtrmac deleted the eof2 branch February 14, 2023 17:43

mtrmac added a commit to mtrmac/libpod that referenced this pull request Feb 14, 2023

Vendor c/image after containers/image#1847

86a4c6b

... for Podman to immediately benefit from the updated heuristic. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

This was referenced Feb 14, 2023

Vendor c/image after EOF heuristic tuning containers/podman#17492

Merged

RFE: Retry individual layer copies #1145

Closed

[release-5.24] Backport retries heuristics updates #1859

Merged

mtrmac mentioned this pull request Apr 12, 2023

Error: writing blob: storing blob to file: unexpected EOF containers/podman#18142

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relax retry heuristics #1847

Relax retry heuristics #1847

mtrmac commented Feb 13, 2023

mtrmac commented Feb 13, 2023

mtrmac commented Feb 13, 2023

mtrmac commented Feb 13, 2023

rhatdan Feb 14, 2023

rhatdan commented Feb 14, 2023

vrothberg left a comment

Relax retry heuristics #1847

Relax retry heuristics #1847

Conversation

mtrmac commented Feb 13, 2023

mtrmac commented Feb 13, 2023

mtrmac commented Feb 13, 2023

mtrmac commented Feb 13, 2023

rhatdan Feb 14, 2023

Choose a reason for hiding this comment

rhatdan commented Feb 14, 2023

vrothberg left a comment

Choose a reason for hiding this comment