Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using cosign-generated private keys with a "SIGSTORE" type #1902

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Mar 30, 2023

Don't (yet) generate them, no released version of cosign can work with them.

Compare Cosign’s change: sigstore/cosign#2735

mtrmac added 2 commits March 30, 2023 07:04
We will add a new key type that actually says sigstore.

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Don't (yet) generate them, no released version of cosign can
work with them.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit e0e3581 into containers:main Mar 30, 2023
@mtrmac mtrmac deleted the sigstore-key-label branch March 30, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants