Improve transport documentation #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
added
the
kind/bug
docs/containers-policy.json.5.md
Outdated
| - a named Docker reference *in the fully expanded form*, either using a tag or digest. For example, `docker.io/library/busybox:latest` (*not* `busybox:latest`) | ||
| - and/or (depending on which one the user’s input provides) `@`_image-id_ | ||
|
|
||
| More general scopes are prefixes of individual-image scopes, and specify a less-precisly-specified image, or a repository |
There was a problem hiding this comment.
Suggested change
| More general scopes are prefixes of individual-image scopes, and specify a less-precisly-specified image, or a repository | |
| More general scopes are prefixes of individual-image scopes, and specify a less-precisely-specified image, or a repository |
|
One small typo, otherwise LGTM. |
- Separate the code imports from transport-registration imports - Improve the comment about updating documentation - Add a missing comment about docker-daemon - Sort transports, and transport comments alphabetically. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... to match the 2017 docker/reference API migration. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
- Add missing sif: - Add comments about intentionally-excluded atomic: and tarball: - docker-archive: can now transparently handle non-seekable streams - Clarify documentation of references in OCI transports Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…cy.json(5) Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in
containers-transports(5)andcontainers-policy.json(5).See individual commit messages for a bit more detail.
Fixes #1501 .