Make temporary names container/image specific #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Idea SGTM
Build needs massaging:
oci/archive/oci_transport.go:163:40: cannot use dir (variable of type *os.File) as string value in argument to ocilayout.NewReference
oci/archive/oci_transport.go:168:45: cannot use dir (variable of type *os.File) as string value in struct literal
mtrmac
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Thanks, this makes sense to me.
Separately, it could be interesting for Podman or callers to turn Ctrl-C into a context cancellation, to trigger a correct cleanup. OTOH that would be a major change… and IIRC the typical io.Copy (not involving HTTP) is not cancellable, so slow on-disk operations would not stop immediately.
If you hit Ctr-C while pulling an image files and directories get left in /var/tmp. By adding "containers_images" prefix, we can use systemd tmpfiles handling to remove them on reboot safely. Help to make containers/podman#19201 safer. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you hit Ctr-C while pulling an image files and directories get left in /var/tmp. By adding "containers_images" prefix, we can use systemd tmpfiles handling to remove them on reboot safely.
Help to make containers/podman#19201 safer.