BREAKING: Update for move of github.com/theupdateframework/go-tuf/encrypted #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Cosign’s update PR: sigstore/cosign#3128 . |
|
In the linked issue, Cosign is leaning towards keeping compatibility, at least for the very moment. Waiting for them to actually do that… |
|
Cosign, in sigstore/cosign#3183 , simply updated and started generating private keys non-consumable by older versions. So, I guess, let’s do the same? |
SGTM |
|
LGTM |
…rypted The github.com/theupdateframework/go-tuf/encrypted subpackage is deprecated, switch to the new location. Separetely, this is a BREAKING change: the key encryption parameters of encrypted.Encrypt have been changed, so the keys generated by the new code can't be loaded by older implementations. (Old keys can continue to be used by new implementations.) Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
github.com/theupdateframework/go-tuf/encryptedsubpackage is deprecated, switch to the new location.Separately, this is a BREAKING change: the key encryption parameters of
encrypted.Encrypthave been changed, so the keys generated by the new code can't be loaded by older implementations. (Old keys can continue to be used by new implementations.)Let’s coordinate with Cosign on whether to make that change, or whether to keep using the old compatible parameters (using
EncryptWithCustomKDFParameters).