Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the body of (docker load) response to correctly handle errors #2153

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Oct 20, 2023

Fixes #955 .

Tested manually (with a modified Skopeo which uses an invalid tag, not with a "disk full" error).

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Oct 20, 2023

A fairly fresh bug to fix. :^)
LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM

@rhatdan rhatdan merged commit a1f6435 into containers:main Oct 21, 2023
9 checks passed
@mtrmac mtrmac deleted the daemon-dest-errors branch October 23, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copies to docker-daemon: fails silently when there is out of disk
3 participants