Add DockerCompatAuthFilePath to allow login/logout to interoperate #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
approved these changes
Nov 6, 2023
|
At a first glance, that seems impossible - in Docker mode we must reject And either way it’s not necessary for containers/podman#18617, that one starts with an explicit |
mtrmac
force-pushed
the
docker-compat-login
branch
2 times, most recently
from
8dddf38 to
b8f8916
Compare
... so that the Set/Remove functions are together. Only moves unchanged code, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
For now, this is not really helpful, but we will conditionalize the returned values. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... using a new types.SystemContext.DockerCompatAuthFilePath. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
docker-compat-login
branch
from
b8f8916 to
7b94d26
Compare
|
Manual tests show that
And there are the unit tests in this PR. So I think this is ready for review/merging. |
mtrmac
added a commit
to mtrmac/common
that referenced
this pull request
Nov 13, 2023
> go get github.com/containers/image/v5@main > go mod tidy && go mod vendor Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/buildah
that referenced
this pull request
Nov 16, 2023
... to include containers/image#2173 and containers/common#1731 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Nov 16, 2023
... to include containers/image#2173 and containers/common#1731 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/buildah
that referenced
this pull request
Nov 16, 2023
... to include containers/image#2173 and containers/common#1731 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/libpod
that referenced
this pull request
Nov 17, 2023
... to include containers/image#2173, containers/common#1731 and containers/buildah#5143 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the existing
pkg/docker/configcredential API to be used with Docker-compatibleconfig.jsonfiles, using a newtypes.SystemContext.DockerCompatAuthFilePathoption. This should help with containers/podman#18617 ; I plan to expose this option inc/common/pkg/auth, and users would say something likepodman login --docker-file=~/.docker/config.json docker.io(end-user design doc TBD).It must be an option primarily because we want to refuse to write namespaced credentials when writing to
.docker/config.json.Also add interoperability testing between c/image and
docker/cli, to the extent cheaply possible (e.g.docker/cli, understandably, is not structured to trigger the “write credentials” code ofloginwithout trying to actually login — so the tests use a somewhat lower-level API and need to duplicate some of the logic.I was considering introducing this option with a new functional-option API instead of continuing with problematic
SystemContext, butpkg/docker/configdepends onsysregistriesv2for the credential helpers list, so that would be a rather invasive change.WIP, filed for early review on the API. Cc: @vrothberg