Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a redundant function call #2379

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Avoid a redundant function call #2379

merged 2 commits into from
Apr 23, 2024

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Apr 16, 2024

This primarily ensures that we log and use the same value.

Should not change behavior.

@mtrmac
Copy link
Collaborator Author

mtrmac commented Apr 18, 2024

Added one more trivial cleanup.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mtrmac added 2 commits April 22, 2024 20:42
This primarily ensures that we log and use the same value.

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
The caller logs the same thing, and is in better position to
make the decision.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Apr 23, 2024

LGTM

@rhatdan rhatdan merged commit 387b45a into containers:main Apr 23, 2024
10 checks passed
@mtrmac mtrmac deleted the redundant branch April 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants