Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp codespell #2498

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Revamp codespell #2498

merged 7 commits into from
Aug 5, 2024

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Aug 2, 2024

This

  • silences some codespell warnings where it makes sense to rename a variable etc.;
  • simplifies codespell config to have less exclusions;
  • fixes those warnings that are actual typos.

Split into small commits for easier review.

This is to prevent codespell from complaining about pathc -> patch.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Use ok instead of isT and isV, and limit the variables scope.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
s/doesnt/does-not/

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This just changes fo to f, without disrupting the test.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This fixes a comment in the test code ("expection", "out", and
punctuation) to the best of my knowledge.

Fixes: c84a3fa ("copy/multiple_test: multiple copy requests of same compression")
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

Nice; I have codespell 2.2.6 locally, while in CI we use 2.3.0 which (thanks to cleaned .codespellrc) caught yet another typo:

Error: ./copy/single.go:217: resuing ==> reusing, resuming, rescuing

Found by codespell 2.3.0:

	Error: ./copy/single.go:217: resuing ==> reusing, resuming, rescuing

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Current .codespellrc contains too many exclusions, and as a result it
misses some legitimate typos.

A few previous commits silenced or fixed some of the codespell warnings
in preparation for this one, which minimizes exclusions, and fixes the
actual remaining typos.

The fixes here are the result of codespell -w.

./copy/sign_test.go:119: overidden ==> overridden
./copy/encryption.go:51: pratice ==> practice
./copy/multiple_test.go:80: crated ==> created
./copy/progress_bars.go:124: progres ==> progress

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@rhatdan
Copy link
Member

rhatdan commented Aug 4, 2024

LGTM

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtrmac mtrmac merged commit bc4cff0 into containers:main Aug 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants