Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCI layout extensions #2633

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Nov 14, 2024

Taken over from #2567 but:

  • Added tests for the three commits
  • Use reflinks when adding a file

@vrothberg
Copy link
Member Author

In draft for now.

oci/layout/oci_dest.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick skim; I’m afraid I didn’t read the added tests yet.

oci/layout/oci_dest.go Outdated Show resolved Hide resolved
oci/layout/oci_dest.go Outdated Show resolved Hide resolved
oci/layout/oci_dest.go Outdated Show resolved Hide resolved
@vrothberg vrothberg force-pushed the layout-list branch 3 times, most recently from ae7457e to 234b45f Compare November 19, 2024 09:41
@vrothberg
Copy link
Member Author

I'd love to have some explicit test condition on Linux to make sure that the reflinking works. We're using the function from c/storage which is e2e tested. The unit tests run on tmp, so we have to create the test dirs in $HOME ... not sure we should though.

@vrothberg vrothberg marked this pull request as ready for review November 19, 2024 12:11
Images in the index can now be referenced via the @sourceIndex syntax.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
The new API allows for listing all manifests in an OCI layout's index.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Try to reflink the file and restort to copying it in case of failure.
Also add an Options struct to be future proof.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants