-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCI layout extensions #2633
base: main
Are you sure you want to change the base?
OCI layout extensions #2633
Conversation
In draft for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick skim; I’m afraid I didn’t read the added tests yet.
ae7457e
to
234b45f
Compare
I'd love to have some explicit test condition on Linux to make sure that the reflinking works. We're using the function from c/storage which is e2e tested. The unit tests run on tmp, so we have to create the test dirs in $HOME ... not sure we should though. |
Images in the index can now be referenced via the @sourceIndex syntax. Signed-off-by: Miloslav Trmač <mitr@redhat.com> Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
The new API allows for listing all manifests in an OCI layout's index. Signed-off-by: Miloslav Trmač <mitr@redhat.com> Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Try to reflink the file and restort to copying it in case of failure. Also add an Options struct to be future proof. Signed-off-by: Miloslav Trmač <mitr@redhat.com> Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
234b45f
to
6481647
Compare
Taken over from #2567 but: