Don’t load the manifest in GetSignatures if the digest is known #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are supplied a digested reference, use it instead of possibly fetching the manifest. This allows using signatures which are not protected even if the manifest is, in some situations; in ordinary operation accessing the whole image, this does not make any difference because we are fetching the manifest either way. To ensure consistent behavior, only use the reference digest if it uses the digest.Canonical algorithm, which has been used so far. This could be perhaps relaxed in the future. Note that this does not promise that GetSignatures will never need authentication—e.g. for X-Registry-Supports-Signatures this already depends on the server, and for the sigstore lookaside authentication support may be added in the future. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
LGTM, thanks @mtrmac This means that using digest as part of the image pull spec will pickup that digest without manifest retrieval, right? |
Yes, AFAICS.
Yes. |
|
@runcom lgty? need this and context to complete the signature import for 3.6.1 |
|
LGTM |
|
@mtrmac feel free to LGTM yourself and merge |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are supplied a digested reference, use it instead of possibly fetching the manifest. This allows using signatures which are not protected even if the manifest is, in some situations.
To ensure consistent behavior, only do this if the reference uses the
digest.Canonicalalgorithm, which has been used so far. This could be perhaps relaxed in the future.Note that this does not promise that GetSignatures will never need authentication—e.g. for
X-Registry-Supports-Signaturesthis already depends on the server, and for the sigstore lookaside authenticationsupport may be added in the future.
Cc: @mfojtik