Support <version>-immutable tagged stable images #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevich
force-pushed
the
imutable_stable_images
branch
20 times, most recently
from
43cc927
to
44b3dbe
Compare
|
@edsantiago it's probably asking a lot, so PLMK if it's asking too much for you to review this. Esp. the "Simplify image-build automation scripts" commit is quite big since it prunes out a lot of legacy crap. I did perform a few runs of CI against just that commit, and they're happy. |
|
@TomSweeneyRedHat would you mind taking a look at the (short) README updates here, LMK if there are any major problems? |
edsantiago
reviewed
Apr 17, 2024
|
@edsantiago NP at all if this is too much, I appreciate you're making an effort. |
The current and prior CI VMs contain cached copies of the latest Fedora container image for each arch. Unfortunately the last arch pulled is `arm64`, which results in it being the default image used by podman when `--arch` is not specified. Ensure this can never cause problems by hard-coding the `amd64` arch which will always match the VM. Signed-off-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Chris Evich <cevich@redhat.com>
|
Couple doc changes for consideration or to be ignored. Your call. |
cevich
force-pushed
the
imutable_stable_images
branch
from
44b3dbe
to
485bc4c
Compare
Previously the `containers_build_push.sh` script was "installed" every time into the environment due to legacy architecture reasons. This is no-longer necessary, complex, confusing, and potentially fragile. Move the scripts under the `ci` directory and arrange for them to simply be run from there. Update tests, documentation, comments accordingly. Signed-off-by: Chris Evich <cevich@redhat.com>
There are circumstances where it's consequential to have image digests that change constantly. Add a "flavor" of podman/buildah/skopeo image with a unique tag, that's only ever pushed once. Update documentation. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
force-pushed
the
imutable_stable_images
branch
from
485bc4c
to
99c40a5
Compare
|
This is ready to go, letting it sit for a day or so in case there are last minute objections/feedback. |
|
Note to me: Check next cron run and verify immutable images have been pushed. Send mail to podman list assuming images aren't overwritten on the subsequent cron run. |
cevich
added a commit
to cevich/automation
that referenced
this pull request
Apr 22, 2024
Prior to containers/image_build#23 the automation using `build-push.sh` always pushed its images. This obscured a bug that occurs when `fqin_names` is an empty string in `get_manifest_tags()`. In this case, the `grep` command will exit non-zero, causing `push_images()` to: ``` die "Error retrieving set of manifest-list tags to push for '$FQIN'" ``` Fix this by adding an empty-string check and removing the unnecessary `grep`. Also, `push_images()` change `die "No FQIN(s) to be pushed."` into a warning, since the condition should not be considered fatal. Signed-off-by: Chris Evich <cevich@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: containers/automation_images#310
There are circumstances where it's consequential to have image digests
that change constantly. Add a "flavor" of podman/buildah/skopeo image
with a unique tag, that's only ever pushed once. Update documentation.