Podman/Buildah: Add uCPP package via new build-arg #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iluminae @vrothberg @Luap99 @rhatdan PTAL and LMK if this is good enough. Esp. if the |
Luap99
reviewed
Jun 18, 2024
|
If it helps, I pushed a locally built test-image as |
Since podman supports use of a `#include` directive in `Containerfile` it's prudent to include the tooling necessary to fully make use of this feature. Add a symlink from `cpp` -> `ucpp` as there isn't one by default. Also, since downstream users of the podman image may want a way to more easily customize the package list, de-duplicate the specification via a new build-arg. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
changed the title
It's unlikely that a full-blown C pre-pocessor is required. My understanding is this package was added in order to support the `Containerfile.in` `#include` feature. This can easily be accomplished with `ucpp` at a greatly reduced overall image size. Realize this effect while de-duplicating the package list via a build-arg. Signed-off-by: Chris Evich <cevich@redhat.com>
|
Force-push: Switch buildah image from |
|
Manually tested new podman and buildah images. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
Since podman supports use of a
#includedirective inContainerfileit's prudent to include the tooling necessary to fully make use of this
feature. Add a symlink from
cpp->ucppas there isn't one bydefault.
Also, since downstream users of the podman image may want a
way to more easily customize the package list, de-duplicate
the specification via a new build-arg.