run: Add support for --bind (on linux, with virtiofsd) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prep for adding virtiofs support. See fedora-selinux/selinux-policy#2124 for the tracker. Signed-off-by: Colin Walters <walters@verbum.org>
This is extremely useful for local development cases, as I can e.g. bind mount binaries I built on the host system. Signed-off-by: Colin Walters <walters@verbum.org>
germag
reviewed
May 20, 2024
Comment on lines
+62
to
63
| runCmd.Flags().StringArrayVar(&vmConfig.BindMounts, "bind", nil, "Create a virtiofs mount between host and guest, separated by a `:`") | ||
| } |
There was a problem hiding this comment.
why not using "-v/--volume"?, even if not a great name is more coherent with podman
There was a problem hiding this comment.
Right, sorry when working on this I'd been in a mindset of porting features from coreos-assembler run. Will change.
|
Maybe time to revive this PR? |
I'm ok with this PR, but I still think it's worth changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extremely useful for local development cases, as
I can e.g. bind mount binaries I built on the host system.
Signed-off-by: Colin Walters walters@verbum.org