disk: Don't pass stdin to install run, also set up cancellation #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression in the previous commit; the attachment takes over stdin and was competing with the ssh client. We have no need for interactivity, so don't pass stdin. While we're here, also set up cancellation for the attachment so that we know the operation is done when exiting the function, as we also want to transfer ownership of stdout/stderr back. Signed-off-by: Colin Walters <walters@verbum.org>
ckyrouac
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in the previous commit; the attachment takes over stdin and was competing with the ssh client. We have no need for interactivity, so don't pass stdin.
While we're here, also set up cancellation for the attachment so that we know the operation is done when exiting the function, as we also want to transfer ownership of stdout/stderr back.