Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for cache_from and cache_to fields #1092

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

flixman
Copy link
Contributor

@flixman flixman commented Dec 28, 2024

Currently the fields cache_from and cache_to on the build are ignored. This PR provides support for them in the build block, just by propagating them to the call to podman.

Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It looks good in principle.

What's missing:

Also, podman build documentation says that cache-from is ignored unless --layers is specified. I suppose this PR won't do what user expects as is, what am I missing?

@p12tic
Copy link
Collaborator

p12tic commented Dec 29, 2024

Also, please rebase instead of merging main, thanks!

Signed-off-by: Felix Rubio <felix@kngnt.org>
@flixman
Copy link
Contributor Author

flixman commented Dec 30, 2024

@p12tic About the --layers flag: I also saw the documentation, but I made a couple of tests and caches are used regardless on --layers being set or not. I have just reported this to podman, because looks like might be an error on the documentation.

@flixman
Copy link
Contributor Author

flixman commented Dec 30, 2024

@p12tic about the branch update (merging vs rebasing): Can't the "update with merge" be disabled on the GH UI? I just clicked on "update" and it did a merge. Now I have seen I had the option to "update with rebase", but if that is not valid... maybe should just not appear at all?

@p12tic
Copy link
Collaborator

p12tic commented Dec 30, 2024

Can't the "update with merge" be disabled on the GH UI? I just clicked on "update" and it did a merge.

Unfortunately github UI does not support this. They have different options for actual merging, but for the update button - no.

Signed-off-by: Felix Rubio <felix@kngnt.org>
@p12tic
Copy link
Collaborator

p12tic commented Jan 3, 2025

Still needs a release note.

  • release note. Please see newsfragments/README.txt file

Signed-off-by: Felix Rubio <felix@kngnt.org>
@flixman
Copy link
Contributor Author

flixman commented Jan 3, 2025

Gosh, too many holidays. Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants