You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[vite-plugin-svelte] [plugin vite-plugin-svelte] ../../node_modules/@podman-desktop/ui-svelte/dist/tooltip/Tooltip.svelte (76:17): /home/runner/work/podman-desktop-extension-bootc/podman-desktop-extension-bootc/podman-desktop-extension-bootc/node_modules/@podman-desktop/ui-svelte/dist/tooltip/Tooltip.svelte:76:17 $tooltipHidden is an illegal variable name. To reference a global variable called $tooltipHidden, use globalThis.$tooltipHidden
Describe the solution you'd like
We went through a phase where we would dabble in svelte 5 where it made sense; more recently new components have to be svelte 5. However, we are hitting multiple cases where the existing code in ui-svelte has minor issues with v5 and newer typecheck / vite-plugin-svelte is reporting it in adopting repos.
Handling these as one-offs would be painful, and has a higher likelihood that a change like on:x to onX will cause a regression in an extension. We need a focused port to svelte 5 and ensure the build is picking up issues. Prior to this issue, extensions should hold back on updating faster than where ui-svelte is.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
I think we still need to carry this as tech debt for issues like #9313 though - we need extensions not to push the limits on using svelte 5 with ui-svelte until we have some focus on upgrading more of it. Doing it in pieces / reacting will be more painful and have more releases that break existing use.
Is your enhancement related to a problem? Please describe
See #9313, and containers/podman-desktop-extension-bootc#900 (error from dependabot build picking up podman-desktop/ui-svelte 1.13 in bootc):
[vite-plugin-svelte] [plugin vite-plugin-svelte] ../../node_modules/@podman-desktop/ui-svelte/dist/tooltip/Tooltip.svelte (76:17): /home/runner/work/podman-desktop-extension-bootc/podman-desktop-extension-bootc/podman-desktop-extension-bootc/node_modules/@podman-desktop/ui-svelte/dist/tooltip/Tooltip.svelte:76:17
$tooltipHidden
is an illegal variable name. To reference a global variable called$tooltipHidden
, useglobalThis.$tooltipHidden
Describe the solution you'd like
We went through a phase where we would dabble in svelte 5 where it made sense; more recently new components have to be svelte 5. However, we are hitting multiple cases where the existing code in ui-svelte has minor issues with v5 and newer typecheck / vite-plugin-svelte is reporting it in adopting repos.
Handling these as one-offs would be painful, and has a higher likelihood that a change like on:x to onX will cause a regression in an extension. We need a focused port to svelte 5 and ensure the build is picking up issues. Prior to this issue, extensions should hold back on updating faster than where ui-svelte is.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: