Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ui library component packaging #9340

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Oct 11, 2024

What does this PR do?

the package was not embedding the tsconfig.json file but svelte-compiler relies on it

Screenshot / video of UI

What issues does this PR fix or reference?

containers/podman-desktop-extension-ai-lab#1889
containers/podman-desktop-extension-bootc#900

How to test this PR?

  • Tests are covering the bug fix or the new feature

the package was not embedding the tsconfig.json file but svelte-compiler relies on it

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner October 11, 2024 12:00
@benoitf benoitf requested review from dgolovin, deboer-tim and axel7083 and removed request for a team October 11, 2024 12:00
Copy link
Contributor

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to 'test' prior to publishing, but change LGTM.

@benoitf
Copy link
Collaborator Author

benoitf commented Oct 11, 2024

@deboer-tim try to add inside the local copy of @podman-desktop/ui-svelte folder of the node_modules the tsconfig.json file assuming you're using this branch in for example the project extension-bootc
https://github.com/containers/podman-desktop-extension-bootc/tree/dependabot/npm_and_yarn/podman-desktop/ui-svelte-1.13.2

Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested by copy the podman-desktop#packages/ui/tsconfig.json to the node_modules/@podman-desktop/svelte-ui/tsconfig.json in AI Lab

@benoitf benoitf enabled auto-merge (rebase) October 11, 2024 12:08
@benoitf benoitf merged commit d252fc3 into containers:main Oct 11, 2024
14 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.14.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants