Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testimonial featured link href #197

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fix testimonial featured link href #197

merged 2 commits into from
Oct 17, 2023

Conversation

dnsge
Copy link
Contributor

@dnsge dnsge commented Aug 20, 2023

Description

Fixes the testimonials present at the bottom of https://podman.io to have working links.

Currently, every featured link points to https://podman.io/%7Bprops.featuredlink%7D.

As a side note, I noticed that the Tweet for the first testimonial on the page has since been deleted, so someone may want to find another testimonial to replace that one at some point.

Steps to Reproduce

  1. Navigate to https://podman.io
  2. Scroll to the "What people are saying about Podman" section
  3. Click on one of the featured links in one of the testimonies, e.g. the GitHub link in Fang-Pen Lin's tweet.
  4. Notice that we navigate to https://podman.io/%7Bprops.featuredlink%7D instead of the tweet

Video:

Screen.Recording.2023-08-21.at.10.58.45.AM.mov

Signed-off-by: Daniel Sage <sagedanielr@gmail.com>
@cgiradkar
Copy link
Collaborator

cgiradkar commented Aug 21, 2023

thanks for the PR.
@dnsge do you have any way to reproduce this issue?

@dnsge
Copy link
Contributor Author

dnsge commented Aug 21, 2023

@cgiradkar Sure. I've updated the base comment with these steps too.

Steps to Reproduce

  1. Navigate to https://podman.io
  2. Scroll to the "What people are saying about Podman" section
  3. Click on one of the featured links in one of the testimonies, e.g. the GitHub link in Fang-Pen Lin's tweet.
  4. Notice that we navigate to https://podman.io/%7Bprops.featuredlink%7D instead of the tweet

Video:

Screen.Recording.2023-08-21.at.10.58.45.AM.mov

Co-authored-by: cgiradkar <135707592+cgiradkar@users.noreply.github.com>
Signed-off-by: Daniel Sage <sagedanielr@gmail.com>
@TomSweeneyRedHat
Copy link
Member

@mairin FYI

@cgiradkar
Copy link
Collaborator

cgiradkar commented Sep 12, 2023

@mairin is this the same as #122 ?

@rhatdan
Copy link
Member

rhatdan commented Oct 13, 2023

Can we close this PR?

@cgiradkar
Copy link
Collaborator

LGTM

@rhatdan rhatdan merged commit d17cf62 into containers:main Oct 17, 2023
@dnsge dnsge deleted the fix/testimonial-featured-link-href branch October 18, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants