-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong order of code blocks #235
Conversation
@GabiNecasova the PR needs signoff:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TomSweeneyRedHat PTAL
cc @brlin-tw
src/pages/get-started.tsx
Outdated
$ man podman subcommand {'\n'} | ||
$ podman --help # get a list of all commands {'\n'} | ||
$ podman subcommand --help # get info on a command{' '} | ||
{'\n'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, but don't know, that this has to be at the end fo the previous line. @cgiradkar do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomSweeneyRedHat I tried to modify the code as:
$ podman --help # get a list of all commands {'\n'}
$ podman subcommand --help # get info on a command{'\n'}
and the result is the same (please see the screenshot below). I tried to build it locally (yarn build & yarn serve
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, but don't know, that this has to be at the end fo the previous line. @cgiradkar do you know?
I agree, the extra carriage returns are not needed hence should be removed.
The rearranging and verbiage LGTM. I'm just not sure about the carriage return before the |
src/pages/get-started.tsx
Outdated
$ podman subcommand --help # get info on a command{' '} | ||
{'\n'} | ||
$ man podman {'\n'} | ||
$ man podman subcommand {'\n'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ man podman subcommand {'\n'} | |
$ man podman subcommand |
c3fcd06
to
f813108
Compare
I removed both unnecessary newlines in the codeblocks. Should be fine now. |
src/pages/get-started.tsx
Outdated
</CodeBlock> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another blank line introduced, plz clear that and squash and commit into 1 commit and force push |
Signed-off-by: Gabriela Necasova <gnecasov@redhat.com> Removed newlines Signed-off-by: Gabriela Necasova <gnecasov@redhat.com>
@cgiradkar Thank you for your note! I squashed commits as requested. |
LGTM |
LGTM |
I can verify that the defect is indeed fixed, thanks @GabiNecasova ! |
@brlin-tw My pleasure 🙂 |
Fixes: #231