Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong order of code blocks #235

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

GabiNecasova
Copy link
Collaborator

Fixes: #231

@lsm5
Copy link
Member

lsm5 commented Nov 6, 2023

@GabiNecasova the PR needs signoff:

$ git commit --amend -s
# Save it
$ git push -f

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ man podman subcommand {'\n'}
$ podman --help # get a list of all commands {'\n'}
$ podman subcommand --help # get info on a command{' '}
{'\n'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, but don't know, that this has to be at the end fo the previous line. @cgiradkar do you know?

Copy link
Collaborator Author

@GabiNecasova GabiNecasova Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomSweeneyRedHat I tried to modify the code as:

$ podman --help # get a list of all commands {'\n'}
$ podman subcommand --help # get info on a command{'\n'}

and the result is the same (please see the screenshot below). I tried to build it locally (yarn build & yarn serve).
Screenshot from 2023-11-06 11-17-21

Copy link
Collaborator

@cgiradkar cgiradkar Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, but don't know, that this has to be at the end fo the previous line. @cgiradkar do you know?

I agree, the extra carriage returns are not needed hence should be removed.

@TomSweeneyRedHat
Copy link
Member

The rearranging and verbiage LGTM. I'm just not sure about the carriage return before the \n block.

src/pages/get-started.tsx Outdated Show resolved Hide resolved
$ podman subcommand --help # get info on a command{' '}
{'\n'}
$ man podman {'\n'}
$ man podman subcommand {'\n'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ man podman subcommand {'\n'}
$ man podman subcommand

@GabiNecasova GabiNecasova force-pushed the fix-231 branch 2 times, most recently from c3fcd06 to f813108 Compare November 7, 2023 16:06
@GabiNecasova
Copy link
Collaborator Author

I removed both unnecessary newlines in the codeblocks. Should be fine now.

</CodeBlock>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@cgiradkar
Copy link
Collaborator

I removed both unnecessary newlines in the codeblocks. Should be fine now.

There's another blank line introduced, plz clear that and squash and commit into 1 commit and force push

Signed-off-by: Gabriela Necasova <gnecasov@redhat.com>

Removed newlines

Signed-off-by: Gabriela Necasova <gnecasov@redhat.com>
@GabiNecasova
Copy link
Collaborator Author

@cgiradkar Thank you for your note! I squashed commits as requested.

@cgiradkar
Copy link
Collaborator

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM
Welcome to the Podman.io community @GabiNecasova !

@TomSweeneyRedHat TomSweeneyRedHat merged commit bbb5739 into containers:main Nov 8, 2023
3 checks passed
@brlin-tw
Copy link

brlin-tw commented Nov 10, 2023

I can verify that the defect is indeed fixed, thanks @GabiNecasova !

@GabiNecasova
Copy link
Collaborator Author

@brlin-tw My pleasure 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong order of text in the Getting Help section of the "Get Started with Podman" page
5 participants