Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "DO NOT MERGE - Test for Build" #286

Closed
wants to merge 1 commit into from

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Mar 13, 2024

This reverts commit 2bd5970. AS the name suggest this should not have been commited to main, no idea how this ended up there. It does not seem to be merged via PR[1] so it was likely pushed directly.

[1] #280

This reverts commit 2bd5970.
AS the name suggest this should not have been commited to main, no idea
how this ended up there. It does not seem to be merged via PR[1] so it
was likely pushed directly.

[1] containers#280

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99
Copy link
Member Author

Luap99 commented Mar 13, 2024

@TomSweeneyRedHat PTAL, did you pushed this to main directly by accident?
I wonder why branch protection did not prevent this?

@TomSweeneyRedHat
Copy link
Member

@Luap99 I honestly don't know what happened on this one. Last night I was trying to push a PR to add the notes from the latest Cabal meeting. However, the usual button to finalize the GitHub PR submission never appeared. I retried several times, but the PR never showed, and then I noticed this change was now part of the repo unexpectedly. The notes that I tried adding were not present.

So this morning, I trashed my sandbox and retried with the removal of the "TEST" from the README.md, and it worked fine.

I think the lesson is that on a day when I only got 5 hours of sleep, I shouldn't try to push PRs at the end of a 12-hour day.

On top of that, I swore I had closed this already. Doing so now....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants