Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker incompatbility: status message on streamed push #12468

Closed
leahneukirchen opened this issue Dec 1, 2021 · 1 comment · Fixed by #12483
Closed

Docker incompatbility: status message on streamed push #12468

leahneukirchen opened this issue Dec 1, 2021 · 1 comment · Fixed by #12483
Labels
HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@leahneukirchen
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Different status string formatting for the compat API than in Docker.

Steps to reproduce the issue:

When using the compat API to push an image, podman responds with a status like this:

{"status":"mytag: digest: sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"}

However, Docker responds with

{"status":"mytag: digest: sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff size: 1234"}

This caused a bug in production software that assumed size: is included too.

If you think API differences like this are out of scope for Podman, please close as invalid and I'll stop reporting them.

Describe the results you received:

The status field has no size:.

Describe the results you expected:

The status field contains size: 1234, like in Docker.

Output of podman version:

podman version 3.4.2

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/master/troubleshooting.md)

Yes, same code in HEAD.
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 1, 2021
@rhatdan
Copy link
Member

rhatdan commented Dec 1, 2021

This seems like a legitimate bug.

rhatdan added a commit to rhatdan/podman that referenced this issue Dec 1, 2021
@rhatdan
Return size on compatibility push
4c4f30f 
Fixes: containers#12468

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan mentioned this issue Dec 1, 2021
Closed
vrothberg pushed a commit to vrothberg/libpod that referenced this issue Dec 2, 2021
@rhatdan @vrothberg
compat API: push: report size of manifest
8d6d9df 
We don't yet have a local registry running in the APIv2 tests.
Tested manually.

[NO NEW TESTS NEEDED]

Fixes: containers#12468

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg vrothberg mentioned this issue Dec 2, 2021
Merged
@mheon mheon added the HTTP API Bug is in RESTful API label Dec 2, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
3 participants
@leahneukirchen @rhatdan @mheon